MXP: <SEND> ignores text between open and close tags

[xtian]

Spec violation:

<SEND href="bla">blubb</SEND>

should display "blubb" but on click, the sent command should be "bla".

Mudlet displays "bla" instead.

See also:

http://www.zuggsoft.com/zmud/mxp.htm (search for "<SEND>")

[Vadim Peretokin (vperetokin)]

Where can we test this while fixing it?

[xtian (xtian-avalon)]

On 05.01.2014, at 01:13, Vadim Peretokin <email address hidden> wrote:

> Where can we test this while fixing it?
>

give me a day or three to build you a test case.

cheers,
xt

> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1265379
>
> Title:
> MXP: <SEND> ignores text between open and close tags
>
> Status in Mudlet the MUD client:
> New
>
> Bug description:
> Spec violation:
>
> <SEND href="bla">blubb</SEND>
>
> should display "blubb" but on click, the sent command should be "bla".
>
> Mudlet displays "bla" instead.
>
>
> See also:
>
> http://www.zuggsoft.com/zmud/mxp.htm (search for "<SEND>")
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1265379/+subscriptions

[Vadim Peretokin (vperetokin)]

Thanks a ton

[xtian (xtian-avalon)]

Ok. So, I have to retract parts of my statement, as the problem happens in a very specific test case.

The /exact/ test-case is:

<SEND href="#">blubb</SEND>

So, when the command-to-send is a hash.
I checked-out the specs again, and found nothing why the hash should not be used for this.

You can test it here:

- connect to avalon.mud.de
- (wait 3s)
- on the login-screen just type (ignore everything else): "term mudletbug". The second line has the link that is not working.

thanks,
xtian

[Stephen Lyons (slysven)]

Humm, I know very little about MXP but I was looking through
http://www.zuggsoft.com/zmud/mxp.htm to try and get my head around this
and my first though is that "#" is a reserved character in (HTTP:) URIs
see http://tools.ietf.org/html/rfc3986#section-2.2 (<- note the use here
of "#" and you might see what it is reserved FOR!)

On 31/01/14 12:44, xtian wrote:
> Ok. So, I have to retract parts of my statement, as the problem happens
> in a very specific test case.
>
> The /exact/ test-case is:
>
> <SEND href="#">blubb</SEND>
>
> So, when the command-to-send is a hash.
> I checked-out the specs again, and found nothing why the hash should not be used for this.
>
>
> You can test it here:
>
> - connect to avalon.mud.de
> - (wait 3s)
> - on the login-screen just type (ignore everything else): "term mudletbug". The second line has the link that is not working.
>
>
> thanks,
> xtian
>

[xtian (xtian-avalon)]

In HTML, absolutely. But in MXP, I don't know. I even don't know if it should be. I couldn't find anything in the specs.

On the other hand, Mushclient does work with the "#" command. Maybe somebody could test it with other clients?

[Stephen Lyons (slysven)]

I understand, and not wishing to put anything libellous, it does seem that Zugg has created specifications that do have some areas of, how shall I put it, *uncertainty*...:

http://www.mudbytes.net/index.php?a=topic&t=3808

[Stephen Lyons (slysven)]

Ah, Mudbytes has revamped itself - the reference is now: http://www.mudbytes.net/forum/topic/3808/ but my original comments still stand though, '#' is a reserved character in a URI in that it precedes the optional "fragment" part of the URI, see: https://en.wikipedia.org/wiki/Uniform_resource_locator.

[xtian (xtian-avalon)]

I would still argue that, yes - what you say is true concerning HTML.

But this is not HTML, nowhere is it said that MXP should be parsed via a HTML parser and, mainly, that commands aren't a URI.

Also, it works in Mushclient, which one can regard as a gold standard.

[Stephen Lyons (slysven)]

Um, in Zugg's specification at: http://www.zuggsoft.com/zmud/mxp.htm you have:
...
Overview of MXP

MXP is based loosely on the HTML and XML standards supported by modern web browsers. It is only "loosely" based upon these standards because MUDs require dynamic, streaming text, rather than the page-oriented view of web browsers. Also, the existing standards are needlessly verbose for use on a MUD where text efficiency is important.
...
Links
<A href=URL [hint=text] [expire=name]>
    The <A> tag works as it does in HTML to open a web page in the user's web browser. When the mouse hovers over the link, the optional "hint" text is displayed. If the hint text is not given, the URL of the link will be shown in the hint box. The Expire name is used for links that expire. See the <expire> tag for more details.

    The http:// URL will open the user's external web browser to the specified web page. The telnet:// URL will open another window for the specified telnet address and port. The mailto: URL will open your email client allowing you to send email to the specified address.

    Example: <A "http://www.zuggsoft.com>Click here for zMUD</A>
...

However perhaps you DO have a case, the relevant method is (void)TBuffer::translateToPlainText(std::string &) and looking at it I am coming to the conclusion that it is an ugly motherf***** piece of code (in my humble opinion) - hell, it even has a couple of different "goto"s in it! I was studying it as I wanted to add the necessary stuff so that it could parse an incoming multi-byte Utf-8 encoded data-stream but the partial MXP implementation in there is making things even more complex than it otherwise would be - the more I gaze into the abyss - the more I get the feeling something is looking back at me...

[Stephen Lyons (slysven)]

Changing back to "Confirmed" - but only "Low" priority because it needs to be looked at but it needs someone with a really good grip on things to do it and *I* don't feel I have the skills/balls to do it.

[Vadim Peretokin (vperetokin)]

Migrating issues to Github, please follow the new discussion here: https://github.com/Mudlet/Mudlet/issues/568

This issue needs to be closed and there is no appropriate status, so will set it to "Opinion" just for migration purposes.