Closing session console not closing built-in mapper in multiple sessions

[Stephen Lyons]

Running my development version based on current repository I noticed that if I ran multiple sessions and used the built-in mapper (not geyser one) and closed a session by clicking the close button on the tab the corresponding mapper was not removed. On restarting the profile (without closing the other session(s)/mudlet itself) a new built-in mapper was successfully created - the original one was still functional (at least as far as changing exits and moving rooms within area) but changes in its data were not saved when I eventually did exit that instance of mudlet.

This'll need checking in a "proper" version but I suspect the same will apply, a fix must ensure closing the profile closes the matching mapper if the built-in one is in use - I guess a geyser one would be closed down but I don't know that.

Reason why I use the built-in one: I can drag it (the dock widget that it is in) to a second monitor in a virtual (multi-monitor) display set-up...

[Stephen Lyons (slysven)]

Humm, trying this again with a PR I am working on cause a segment violation when operating the second instance of a closed and then re-opened profile with a dock-widget when multi-playing - the 2D mapper crashes at the line in the T2DMap::paintEvent(...) at the point where it tries to get the player room with:

TRoom * pPlayerRoom = mpMap->mpRoomDB->getRoom( mpMap->mRoomIdHash.value( mpHost->getName() ) );

at this time mpHost is NULL and there is not an "abandon this method" check for it at the start of the method.

[Vadim Peretokin (vperetokin)]

Migrating issues to Github, please follow the new discussion here: https://github.com/Mudlet/Mudlet/issues/550

This issue needs to be closed and there is no appropriate status, so will set it to "Opinion" just for migration purposes.