Custom exit lines dialog broken in git

[Vadim Peretokin]

The custom exit lines dialog does not come up in current git, it goes straight to the line-making portion of the workflow.

[Stephen Lyons (slysven)]

Does not seem to for me on the same code I think. I note that the line-making part seems to be initiated as soon as one hits the exit selection buttons in the case of lines for normal exits - given that these are at the top of the dialogue a user unfamiliar could wonder where the dialogue box has disappeared to when that happens before they change the arrow at end option or selected a colour; at that point Mudlet is waiting for the user to draw the first line segment but it may not be obvious if they think that the dialogue box has just disappeared as if something was wrong...

Could an enter keypress or a mouse click have got to the custom exit dialogue AS it is being drawn after you click on the mapper context (right-click) menu so that the dialogue goes straight on as you describe?

[Stephen Lyons (slysven)]

Humm, further inspection lead me to tidy up the custom_lines dialogue as the first few items on the tab order were the various normal exits - so if an "Enter" key press had got to that dialogue there was a fair chance that it would progress as described. On the whole though don't necessarily think this is the sole explanation. I have found that when a custom exit line is deleted (by highlighting it and right-clicking to get the context menu with the sole "delete" item) although the coordinates are removed from the TRoom that is being dealt with, the corresponding color, line style and ending arrow options were not being removed for that particular exit.

[Vadim Peretokin (vperetokin)]

I'm not getting the exits dialog at all on latest git. Here is a screencast. Do you see the same thing?

[Heiko (koehnheiko)]

For the time being you can ignore any custom lines related isses as
custum lines is still in the process of being reworked and completely
unfinished at this point.

Am 17.07.2013 11:39, schrieb Vadim Peretokin:
> I'm not getting the exits dialog at all on latest git. Here is a
> screencast. Do you see the same thing?
>
> ** Attachment added: "No exits dialog.mp4"
> https://bugs.launchpad.net/mudlet/+bug/1201017/+attachment/3739754/+files/No%20exits%20dialog.mp4
>

[Vadim Peretokin (vperetokin)]

Ok

[Stephen Lyons (slysven)]

Just checking something else and found that the custom_lines.ui file has been "improved" (I think it was suggested that all the exits should be listed in a table for the user to select one from) and all the push buttons for the normal exits have been removed (by Heiko in commit f30a55). Unfortunately the existing code in T2DMap::slot_setCustomLine() explicitly hunts for those push buttons and bails out prematurely if it can't find them - which it now can't do - execution then proceeds to the next step which is to start to draw out the line on the next mouse click!

The simplest fix will be to revert the changes specific to custom_line.ui until the other code has been updated to work.

[Vadim Peretokin (vperetokin)]

Agreed on the fix. The new interface is half-finished - doesn't scale
properly, has cut-off text, and makes zero use of any layouts.

[Stephen Lyons (slysven)]

I'm now happy with my fix/enhancement to custom lines stuff which is waiting for peer review(?) into Chris7/Mudlet2/mudletDev and then propagation upstream.

[Stephen Lyons (slysven)]

https://github.com/Mudlet/Mudlet/pull/87 should address current functional issues for current proposal - otherwise now implemented in main development branch.

[Stephen Lyons (slysven)]

Released in 3.0.0 previews...