'Delete profile' disabled in latest git

[Vadim Peretokin]

This commit: http://sourceforge.net/p/mudlet/code/ci/bfaed1b67efa2e1c76cb2568a731dc71704e662c/tree/src/dlgConnectionProfiles.cpp?diff=666306cf16ab29983b740e4d6a314efb941eade5 introduced a bug which disables the 'Remove' button.

if( profile.size() > 1 ) return;

Makes it so any profile which has a name greater than one character can't be deleted.

Perhaps it is intended to be:

if( profile.size() < 1 ) return;

Instead?

[Vadim Peretokin (vperetokin)]

Delete profile has been disabled, per Heiko:

"Deleting profiles is disabled because of the profile deletion bug has been reported again. Stays disabled until somebody analyses this completely."

[Chris (chrismudlet)]

Can someone provide a link to where this problem is described?

[Heiko (koehnheiko)]

The "problem" is that under certain circumstances a use of the delete
button may delete a random profile :-)
The delete button has been disabled until somebody analyzes the problem.

Am 09.01.2014 15:37, schrieb Chris:
> Can someone provide a link to where this problem is described?
>

[Vadim Peretokin (vperetokin)]

That's not the problem, the problem was elsewhere during profile creation.
It was a long forum post by someone and it is something I've ran into
myself as well - create a new profile and sometimes it'd pick up settings
from another random one.

As for the link, someone would have to dig through the forums to find it.

[Vadim Peretokin (vperetokin)]

Found one post, but that's not the one in question:
http://forums.mudlet.org/viewtopic.php?f=9&t=3549&p=17545&hilit=profile#p17544(points
to profile creation, not deletion).

I went back through all 2013 posts with 'profile' in them, didn't find it.
But anyway, I'd recommend checking both profile deletion and profile
creation procedures.

[Heiko (koehnheiko)]

And what was the problem? I've explicitely disabled this button because
we got some reports of obscure *heavy* data loss due to a not properly
working profile deletion.
Consequently, unless this has been fully resolved, this feature should
imho not get reenabled because it's not safe and people may lose
everything.

Am 27.08.2014 13:01, schrieb Vadim Peretokin:
> ** Changed in: mudlet
> Status: In Progress => Fix Committed
>

[Vadim Peretokin (vperetokin)]

I'm failing to find any reports not on the forums not here, and I've
double-checked the code, and used it - the only thing deleted was what it
should be.

There were data loss issues due to a profile not loading fully because it
didn't properly serialize all characters, bu that is a profile
serialization issue, not a profile deletion one.