Mudlet saves scripts on script window open, not on close

[Demonnicus]

While helping a new user, it was brought to my attention that when you open the scripts window, it saves whatever script was last selected. To test, you can make 2 simple scripts in an empty profile.

Script one, named "Fizz", just does send("Fizz")
Script two, named "Buzz", just does send("Buzz")

If you then click on Fizz, close the script window, and reopen it, it will send "Fizz". Click on Buzz and it will send "Fizz" again, as expected (because it saved the Fizz script, which executes it). If you close the script window while Buzz is selected, it does not send "Buzz" but does send it when you reopen the script window.

Saving the script object when the window opens is unexpected behaviour. It would make sense to either save it when you close the window, or to not save it at all (provide a way out without saving). But saving when you open the window could easily lead to unintended consequences, especially if the user is unaware that this happens. I'm an advanced Mudlet user who's been using it since the very beginning and just found out about the behaviour, so it seems likely most others are unaware of this as well.

Tested using Mudlet-2.1 and Ubuntu 11.04 32bit with PAE.

[Vadim Peretokin (vperetokin)]

Migrating issues to Github, please follow the new discussion here: https://github.com/Mudlet/Mudlet/issues/720

This issue needs to be closed and there is no appropriate status, so will set it to "Opinion" just for migration purposes.