GMCP Client.GUI updates message is reversed

[Vadim Peretokin]

Mudlet said:

<The server wants to upgrade the GUI to new version '3'. Uninstalling old version '10'><Server
offers downloadable GUI (url='http://mud.xyllomer.de:8080/downloads/Xyllomer.mpackage')
(package='Xyllomer')>
<package is already installed>

When the server version for the package was updated from 3 to 10. Not only is the echo on the version numbers wrong (reversed), but it did not uninstall and download the new package either.

[Vadim Peretokin (vperetokin)]

Hm, it seems to be updating just fine now after multiple tries. The only thing wrong is the version number it reports. I made a new branch and fixed this in a commit: https://github.com/vadi2/bug1035992/commit/8381dec84ab0e5592508a42f3daa2d6aac5e1645

[Vadim Peretokin (vperetokin)]

It's not fixed, 2.0 still has this code:

QString _smsg = QString("<The server wants to upgrade the GUI to new version '%1'. Uninstalling old version '%2'>").arg(mpHost->mServerGUI_Package_version).arg(newVersion);

For a test, see bedlam.gotdns.com:9000, where connecting for the first time will tell you:

<The server wants to upgrade the GUI to new version '-1'. Uninstalling old version '2'><Server
offers downloadable GUI (url='http://hud.hopto.org/bedlam/Bedlam_GUI.mpackage')
(package='Bedlam_GUI')>

[Vadim Peretokin (vperetokin)]

Migrating issues to Github, please follow the new discussion here: https://github.com/Mudlet/Mudlet/issues/524

This issue needs to be closed and there is no appropriate status, so will set it to "Opinion" just for migration purposes.