TCP mode doesn't work correctly with two mtr's processes running simultaneously

[grey]

When you use TCP mode in curses interface mode in two mtr processes running simultaneously hops from one process "leaks" to another process.

How to reproduce? First run simultaneously two mtr processes to two different directions A and B in report mode:

* Direction A
[grey@GreyPad tmp]$ mtr -Twrbc10800 onet.pl
Start: Mon Mar 2 21:00:12 2015
HOST: GreyPad Loss% Snt Last Avg Best Wrst StDev
  1.|-- 10.1.0.1 0.0% 10800 248.0 48.8 0.9 7022. 221.6
  2.|-- 89-77-124-1.dynamic.chello.pl (89.77.124.1) 0.0% 10800 171.7 124.8 -1737 18146 28889.2
  3.|-- 89-75-6-1.infra.chello.pl (89.75.6.1) 0.0% 10800 152.6 602.0 -2100 19494 37062.1
  4.|-- 84.116.253.97 0.1% 10800 198.3 -92.5 -1711 62725 18684.4
  5.|-- 84.116.253.118 0.1% 10800 212.8 512.6 7.4 14988 20151.4
  6.|-- pni-pl-krk01a-as12990-onet.aorta.net (62.179.3.254) 0.1% 10800 253.1 623.0 6.5 21460 26760.0
  7.|-- sdr1.m11r2.z.ruc-BR1.net.onet.pl (213.180.151.129) 0.1% 10800 244.7 164.1 -1898 17981 32328.8
  8.|-- sg1.any.onet.pl (213.180.141.140) 0.0% 10800 252.0 101.7 11.0 7035. 196.7

* Direction B
[grey@GreyPad tmp]$ mtr -Twrbc10800 anidb.net
Start: Mon Mar 2 21:00:11 2015
HOST: GreyPad Loss% Snt Last Avg Best Wrst StDev
  1.|-- 10.1.0.1 0.0% 10800 274.8 46.1 0.9 7016. 226.4
  2.|-- 89-77-124-1.dynamic.chello.pl (89.77.124.1) 0.1% 10800 286.4 325.9 -1114 11022 21435.4
  3.|-- 89-75-6-1.infra.chello.pl (89.75.6.1) 0.1% 10800 294.2 503.0 -7319 17199 30614.5
  4.|-- 84.116.253.185 0.1% 10800 258.1 384.7 12.6 18628 20063.2
  5.|-- 84.116.138.94 0.1% 10800 147.4 270.2 -1499 18853 26810.4
  6.|-- 213.46.178.90 0.1% 10800 138.5 655.4 11.4 19693 28885.0
  7.|-- ae-5-5.car2.StLouis1.Level3.net (4.69.201.2) 0.1% 10800 267.0 306.2 -7037 76466 11997.6
  8.|-- 4.28.92.190 0.1% 10800 468.8 330.8 -2093 16223 28388.8
  9.|-- static-ip-209-239-125-4.inaddr.ip-pool.com (209.239.125.4) 0.2% 10800 460.0 1051. -1289 21218 40602.6
 10.|-- static-ip-50-30-46-101.inaddr.ip-pool.com (50.30.46.101) 0.0% 10800 1483. 246.7 179.2 7218. 236.0

Results are normal and are good referential meterial. Second step is to run simultaneously two mtr processes to the same directions A and B but in curses mode:

* Direction A
                                          My traceroute [v0.85]
GreyPad (0.0.0.0) Wed Mar 4 22:39:23 2015
Keys: Help Display mode Restart statistics Order of fields quit
                                                                  Packets Pings
 Host Loss% Snt Last Avg Best Wrst StDev
 1. 10.1.0.1 0.0% 1105 3.0 7.3 0.9 1005. 51.1
 2. 89-77-124-1.dynamic.chello.pl (89.77.124.1) 0.7% 1105 81.4 829.9 9.9 76039 23103
    84.116.138.94
    89-75-6-1.infra.chello.pl (89.75.6.1)
 3. 89-75-6-1.infra.chello.pl (89.75.6.1) 0.7% 1104 66.6 933.9 7.6 57695 21360
    4.28.92.190
    84.116.138.94
 4. 84.116.253.97 0.9% 1104 77.2 40.0 9.4 3071. 123.7
 5. 84.116.253.118 0.1% 1104 58.3 462.5 8.4 47011 14154
    84.116.253.185
 6. pni-pl-krk01a-as12990-onet.aorta.net (62.179.3.254) 0.6% 1104 65.3 34.7 10.1 422.0 43.8
 7. sdr1.m11r2.z.ruc-BR1.net.onet.pl (213.180.151.129) 0.9% 1104 69.6 468.9 11.5 47445 14343
    10.1.0.1
 8. sg1.any.onet.pl (213.180.141.140) 0.0% 1104 130.6 115.1 14.1 1122. 58.5

* Direction B
                                          My traceroute [v0.85]
GreyPad (0.0.0.0) Wed Mar 4 22:39:20 2015
Keys: Help Display mode Restart statistics Order of fields quit
                                                                  Packets Pings
 Host Loss% Snt Last Avg Best Wrst StDev
 1. 10.1.0.1 0.0% 1098 5.8 6.1 0.9 1001. 42.0
 2. 89-77-124-1.dynamic.chello.pl (89.77.124.1) 0.4% 1098 99.4 390.2 11.3 36506 11036
    84.116.253.97
 3. 89-75-6-1.infra.chello.pl (89.75.6.1) 1.1% 1098 78.1 32.6 8.2 882.0 52.5
 4. 84.116.253.185 0.4% 1097 79.3 472.5 15.3 46793 14152
    84.116.253.97
 5. 84.116.138.94 0.4% 1097 95.2 39.4 12.9 1016. 55.5
 6. 213.46.178.90 0.4% 1097 170.2 43.9 15.1 585.7 49.1
 7. ae-5-5.car2.StLouis1.Level3.net (4.69.201.2) 0.5% 1097 276.5 213.4 159.8 1297. 85.0
 8. 4.28.92.190 0.9% 1097 322.1 1133. 176.5 10086 30588
    pni-pl-krk01a-as12990-onet.aorta.net (62.179.3.254)
 9. static-ip-209-239-125-4.inaddr.ip-pool.com (209.239.125.4) 0.6% 1097 281.2 529.7 177.2 35576 10769
    static-ip-209-239-125-3.inaddr.ip-pool.com (209.239.125.3)
    sdr1.m11r2.z.ruc-BR1.net.onet.pl (213.180.151.129)
10. static-ip-50-30-46-101.inaddr.ip-pool.com (50.30.46.101) 0.0% 1097 305.2 222.2 178.9 1048. 55.2

As you can see results are strange. E.g.:

For Direction A 7th hop 10.1.0.1 is the same as 1st.
For Direction A 3th hop 4.28.92.190 is the same as 8th hop in Direction B traceroute.
For Direction B 9th hop 213.180.151.129 is the same as 7th hop in Direction A.

This results are strange because are imposible.

10.1.0.1 is my local router so it can't be 7th hop.
4.28.92.190 is Level3 hop in USA. In reality trafic from me to onet.pl goes only through Polish networks. But 4.28.92.190 is of course normal hop for anidb.net.
213.180.151.129 is IP address in onet.pl datacenter. Referential traceroutes proves that traffic from me to anidb.net doesn't goes through onet.pl datacenter in Krakow in Poland.

I can always reproduce above strange behavior. From my home, my office or from any other place. You just have to wait a couple of minutes and strange hops appears.

[grey (grey-szarodziej)]

This patch resolves the problem.

https://github.com/yvs2014/mtr/commit/ca79a82b75e13558da88643a021630b44bef51e1