Nova may fail to delete images in resize state

[Sergey Nikitin]

If an
authenticated user deletes an instance while it is in resize state,
it will cause the original instance to not be deleted from the
compute node it was running on. An attacker can use this to launch a
denial of service attack. All Nova setups are affected.

Upstream bug: https://bugs.launchpad.net/nova/+bug/1392527

[Sergey Nikitin (snikitin)]

fix for 7.0 https://review.fuel-infra.org/#/c/10892/

[Sergey Nikitin (snikitin)]

fix for 6.1 https://review.fuel-infra.org/#/c/11313/

[Vitaly Gusev (vgusev)]

Verified on 6.0 with packets *nova*mira35+git.2480ca2.bea7645_all.deb from mirror http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-updates-stable-11319/ubuntu

[Vadim Rovachev (vrovachev)]

On 6.1 bug not reproduced after apply patches for bug https://bugs.launchpad.net/mos/+bug/1466077

[Timur Nurlygayanov (tnurlygayanov)]

Marked as Fix Released for 6.1 based on comments from Vadim

[Vitaly Sedelnik (vsedelnik)]

Back to Fix Committed - for updates the convention is to set Fix Released after the publication of MU to indicate that the fix could be consumed from updates mirrors

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Roman Podoliaka <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/13290
Reason: Fixed upstream with another change-id - I9866d8e32e99b9f907921f4b226edf7b62bd83a7

[Alexander Gubanov (ogubanov)]

I've verified on MOS7.0 (build 301) - all works fine!
Proof: http://pastebin.com/UpiA10ve

[Alexander Gubanov (ogubanov)]

I've verified on MOS 8.0 (build 429) - works!
Proof http://pastebin.com/UGippZjc

[Denis Meltsaykin (dmeltsaykin)]

It looks like nobody merged this https://review.fuel-infra.org/#/c/11319/, I'm reopening bug and retargeting it to 6.0-mu-8

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/11319
Submitter: Denis V. Meltsaykin <email address hidden>
Branch: openstack-ci/fuel-6.0-updates/2014.2

Commit: 39826c4227791aa1d0680fc8f40ee6713d886ef4
Author: Sergey Nikitin <email address hidden>
Date: Thu Feb 18 08:25:17 2016

Fixed fail when user tries to delete images in resize state

If InstanceNotFound error is thrown from decorated function,
migration status should be set to 'error', without checking
current migration status.

Conflicts:
        nova/compute/manager.py

Backport patch requires additional method obj_as_admin() in
NovaBase object, so this patch was squashed with
I556d93741f1ee965c960c6099fbf2c57f31c6744

Closes-Bug: #1489775

Change-Id: I95b0ff2be254a2645ab3ddd51b761a8a24c5a751
(cherry picked from commit 500a2372a3921dbb1728fe82c3a6efbb06f373f0)

[Alexander Gromov (agromov)]

Link to the automated test: https://review.gerrithub.io/#/c/279919/