Mirantis OpenStack

pep8 job fails for Heat openstack-ci/fuel-6.0-updates/2014.2

  1. Series 6.0.x
  2. Bug #1516942
Bug #1516942 reported by Sergey Kraynev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Invalid
High
Sergey Kraynev
Mirantis OpenStack 8.0
6.0.x
Fix Committed
High
Sergey Kraynev
Mirantis OpenStack 6.0-updates
6.1.x
Invalid
Undecided
Sergey Kraynev
Mirantis OpenStack 6.1-updates
7.0.x
Invalid
Undecided
Sergey Kraynev
Mirantis OpenStack 7.0-updates
8.0.x
Invalid
High
Sergey Kraynev
Mirantis OpenStack 8.0

Bug Description

Pep8 job fails for Heat openstack-ci/fuel-6.0-updates/2014.2.
(F.e. https://review.fuel-infra.org/#/c/13913/)

It happens due to Heat has own requirement for hacking library:
https://github.com/openstack/heat/blob/stable/juno/test-requirements.txt#L6

which is not matched with global requirements:
https://github.com/openstack/requirements/blob/stable/juno/test-requirements.txt#L6

Due to we use global requirements on our gates pep8 fails for checks from newer version of hacking library.

Revision history for this message
Sergey Kraynev (skraynev) wrote :

Potential fix is to backport patch https://review.openstack.org/#/c/144749/

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/heat (openstack-ci/fuel-6.0-updates/2014.2)

Fix proposed to branch: openstack-ci/fuel-6.0-updates/2014.2
Change author: Pavlo Shchelokovskyy <email address hidden>
Review: https://review.fuel-infra.org/13949

Changed in mos:
status: Triaged → In Progress
Fuel Devops McRobotson (fuel-devops-robot)
Changed in mos:
milestone: 6.0-updates → 8.0
status: In Progress → New
Revision history for this message
Sergey Kraynev (skraynev) wrote :

Right target milestone and status were set.

Changed in mos:
milestone: 8.0 → 6.0-updates
status: New → In Progress
Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

Setting this as Invalid for 6.1 and 7.0 -updates as this bug is 6.0-specific, and milestones were added by robot are not correct.

Fuel Devops McRobotson (fuel-devops-robot)
Changed in mos:
milestone: 6.0-updates → 8.0
status: In Progress → New
Revision history for this message
Sergey Kraynev (skraynev) wrote :

Set invalid for 8.0

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/heat (openstack-ci/fuel-6.0-updates/2014.2)

Reviewed: https://review.fuel-infra.org/13949
Submitter: Denis V. Meltsaykin <email address hidden>
Branch: openstack-ci/fuel-6.0-updates/2014.2

Commit: 73f692b6a47955bbc24d1fa6376ad7adcc17050a
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Feb 15 13:44:47 2016

Update oslo-hacking and disable failing checks

This also brings in newer versions of flake8, pyflakes and pep8,
with new and updated checks.
Some of them fail on our current code base, so first those failing are
disabled.
Most of them will be enabled one-by-one in subsequent patches.

Conflicts:
 tox.ini

Patch was backported from Kilo, so it has conflict with fixed H302
check.
Also E111 error was fixed in file: heat/engine/resources/eip.py
This issue was related with wrong indent.

Closes-Bug: #1516942

Change-Id: Ib5fc4640b33c238ddb4e59a441c6710f607296b1
(cherry picked from commit 46e5897c3eefad875d29c96f997fb772e957b9e1)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.