Admin panel does not work in Horizon for custom role

Bug #1371161 reported by Dmitry Nikishov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Committed
High
Paul Karikh
5.0.x
Won't Fix
High
Unassigned
5.1.x
Fix Committed
High
Paul Karikh
6.0.x
Fix Committed
High
Paul Karikh

Bug Description

I'm making customizations of MOS 5.1 for a certain client, and one of their requests was to use Active Directory as Keystone's backend. The AD is read only.
They don't use default 'admin' role. They define their own name for the admin role (lets say 'customadmin').

After the modification of policy.json for all the services, CLI works fine. However, Horizon does not recognize 'customadmin' as admin.

Once user with role 'customadmin' authenticates, admin tab is missing. This issue is caused by hardcoded "openstack.roles.admin" permission in Horizon's code. It can be fixed by the following command:
grep -Irl "openstack.roles.admin" /usr/share/openstack-dashboard/openstack_dashboard/ | xargs sed -i 's/openstack.roles.admin/openstack.roles.customadmin/g' && service apache2 restart
(See https://bugs.launchpad.net/horizon/+bug/1161144)

Once this command is executed, admin panel appears, though the user can't access any of it's entries (volumes, instances and so on). Horizon displays error message that says: "You do not have permission to access the resource".

Other cloud with all the same configuration except that it uses default 'admin' role name for the admin role, works like a charm.

Update: after a deep dive into horizon's code, I have a hack that allows to access these pages:
remove "admin=True" in the tenant_list() here:
https://github.com/openstack/horizon/blob/stable/icehouse/openstack_dashboard/api/keystone.py#L257
But I'm sure, it can be solved a better way.

affects: fuel → mos
Timur Sufiev (tsufiev-x)
tags: added: horizon
Changed in mos:
assignee: nobody → MOS Horizon (mos-horizon)
Timur Sufiev (tsufiev-x)
Changed in mos:
assignee: MOS Horizon (mos-horizon) → Paul Karikh (pkarikh)
description: updated
Revision history for this message
Dmitry Nikishov (nikishov-da) wrote :

Authorization issue is caused by hardcoded admin role name in django-openstack-auth:
https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/user.py#L262

Revision history for this message
Paul Karikh (pkarikh) wrote :
Revision history for this message
Dmitry Borodaenko (angdraug) wrote :

No update for over a month, is this still in progress?

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Won't touch this bug in 5.0.x branch until explicit request.

For branches 5.1.x and 6.0.x we need another day to build custom version of django-openstack-auth (we have fix in upstream master, but it's not released yet) - well, to try whether it's possible to build it in time for 5.1.1 release or not. If it's too difficult, we'll change the milestone for 5.1.x to 5.1.2 and add this bug as a 'Known Issue' to Release Notes for 5.1.1.

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

It was decided to add this bug to known issues of 5.1.1 and fix it in 5.1.2.

Revision history for this message
Igor Marnat (imarnat) wrote :

Timur,
if we are not going to fix it in 5.1.1, then this bug should somehow disappear from HCF list of bugs, either by changing its status to Won't fix for 5.1.1, or anything else - you might want to clarify this with Dmitry M.

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Setting Won't Fix for 5.0.x because of comment#4

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/1105
project: packages/precise/python-django-openstack-auth
branch: 6.0
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode in User.is_superuser()
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1105/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package horizon has been built for project openstack/horizon
Package version == 2014.2, package release == fuel6.0.mira8.git.5686e49.51406da

Changeset: https://review.fuel-infra.org/1104
project: openstack/horizon
branch: openstack-ci/fuel-6.0/2014.2
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode
status: patchset-created

Files placed on repository:
openstack-dashboard-2014.2-fuel6.0.mira8.git.5686e49.51406da.noarch.rpm
python-django-horizon-2014.2-fuel6.0.mira8.git.5686e49.51406da.noarch.rpm
python-django-horizon-doc-2014.2-fuel6.0.mira8.git.5686e49.51406da.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable-1104/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package horizon has been built for project openstack/horizon
Package version == 2014.2, package release == fuel6.0~mira11+git.5686e49.51406da

Changeset: https://review.fuel-infra.org/1104
project: openstack/horizon
branch: openstack-ci/fuel-6.0/2014.2
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode
status: patchset-created

Files placed on repository:
openstack-dashboard-ubuntu-theme_2014.2-fuel6.0~mira11+git.5686e49.51406da_all.deb
openstack-dashboard_2014.2-fuel6.0~mira11+git.5686e49.51406da_all.deb
python-django-horizon_2014.2-fuel6.0~mira11+git.5686e49.51406da_all.deb
python-django-openstack_2014.2-fuel6.0~mira11+git.5686e49.51406da_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1104/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/1105
project: packages/precise/python-django-openstack-auth
branch: 6.0
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode in User.is_superuser()
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1105/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/1106
project: packages/centos6/python-django-openstack-auth
branch: 6.0
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode in User.is_superuser()
status: patchset-created

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira2.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable-1106/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/865
project: packages/centos6/python-django-openstack-auth
branch: 6.0
author: Max Yatsenko
committer: Timur Sufiev
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira2.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable-865/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/868
project: packages/precise/python-django-openstack-auth
branch: 6.0
author: Max Yatsenko
committer: Timur Sufiev
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-868/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package horizon has been built for project openstack/horizon
Package version == 2014.2, package release == fuel6.0.mira8

Changeset: https://review.fuel-infra.org/1104
project: openstack/horizon
branch: openstack-ci/fuel-6.0/2014.2
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode
status: change-merged

Files placed on repository:
openstack-dashboard-2014.2-fuel6.0.mira8.noarch.rpm
python-django-horizon-2014.2-fuel6.0.mira8.noarch.rpm
python-django-horizon-doc-2014.2-fuel6.0.mira8.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/865
project: packages/centos6/python-django-openstack-auth
branch: 6.0
author: Max Yatsenko
committer: Timur Sufiev
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: change-merged

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira2.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/868
project: packages/precise/python-django-openstack-auth
branch: 6.0
author: Max Yatsenko
committer: Timur Sufiev
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: change-merged

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package horizon has been built for project openstack/horizon
Package version == 2014.2, package release == fuel6.0~mira12

Changeset: https://review.fuel-infra.org/1104
project: openstack/horizon
branch: openstack-ci/fuel-6.0/2014.2
author: Timur Sufiev
committer: Timur Sufiev
subject: Remove admin role name 'admin' hardcode
status: change-merged

Files placed on repository:
openstack-dashboard-ubuntu-theme_2014.2-fuel6.0~mira12_all.deb
openstack-dashboard_2014.2-fuel6.0~mira12_all.deb
python-django-horizon_2014.2-fuel6.0~mira12_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/1744
project: packages/precise/python-django-openstack-auth
branch: master
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-master-1744/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/2088
project: packages/precise/python-django-openstack-auth
branch: 5.1.2
author: Alex Khivin
committer: Alex Khivin
subject: Remove admin role name 'admin' hardcode in User.is_superuser()
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.2-stable-2088/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/2089
project: packages/precise/python-django-openstack-auth
branch: 5.1.2
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.2-stable-2089/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/2090
project: packages/centos6/python-django-openstack-auth
branch: 5.1.2
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira3.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1.2-stable-2090/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package horizon has been built for project openstack/horizon
Package version == 2014.1.3, package release == fuel5.1.2.mira8.git.98dae66.c9b0cb2

Changeset: https://review.fuel-infra.org/2104
project: openstack/horizon
branch: openstack-ci/fuel-5.1.2/2014.1.1
author: Alex Khivin
committer: Alex Khivin
subject: Remove admin role name 'admin' hardcode
status: patchset-created

Files placed on repository:
openstack-dashboard-2014.1.3-fuel5.1.2.mira8.git.98dae66.c9b0cb2.noarch.rpm
openstack-dashboard-theme-2014.1.3-fuel5.1.2.mira8.git.98dae66.c9b0cb2.noarch.rpm
python-django-horizon-2014.1.3-fuel5.1.2.mira8.git.98dae66.c9b0cb2.noarch.rpm
python-django-horizon-doc-2014.1.3-fuel5.1.2.mira8.git.98dae66.c9b0cb2.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1.2-stable-2104/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package horizon has been built for project openstack/horizon
Package version == 2014.1.3, package release == fuel5.1.2~mira6+git.98dae66.c9b0cb2

Changeset: https://review.fuel-infra.org/2104
project: openstack/horizon
branch: openstack-ci/fuel-5.1.2/2014.1.1
author: Alex Khivin
committer: Alex Khivin
subject: Remove admin role name 'admin' hardcode
status: patchset-created

Files placed on repository:
openstack-dashboard-ubuntu-theme_2014.1.3-fuel5.1.2~mira6+git.98dae66.c9b0cb2_all.deb
openstack-dashboard_2014.1.3-fuel5.1.2~mira6+git.98dae66.c9b0cb2_all.deb
python-django-horizon_2014.1.3-fuel5.1.2~mira6+git.98dae66.c9b0cb2_all.deb
python-django-openstack_2014.1.3-fuel5.1.2~mira6+git.98dae66.c9b0cb2_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.2-stable-2104/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package horizon has been built for project openstack/horizon
Package version == 2014.1.3, package release == fuel5.1.2.mira8

Changeset: https://review.fuel-infra.org/2104
project: openstack/horizon
branch: openstack-ci/fuel-5.1.2/2014.1.1
author: Alex Khivin
committer: Alex Khivin
subject: Remove admin role name 'admin' hardcode
status: change-merged

Files placed on repository:
openstack-dashboard-2014.1.3-fuel5.1.2.mira8.noarch.rpm
openstack-dashboard-theme-2014.1.3-fuel5.1.2.mira8.noarch.rpm
python-django-horizon-2014.1.3-fuel5.1.2.mira8.noarch.rpm
python-django-horizon-doc-2014.1.3-fuel5.1.2.mira8.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1.2-stable/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package horizon has been built for project openstack/horizon
Package version == 2014.1.3, package release == fuel5.1.2~mira6

Changeset: https://review.fuel-infra.org/2104
project: openstack/horizon
branch: openstack-ci/fuel-5.1.2/2014.1.1
author: Alex Khivin
committer: Alex Khivin
subject: Remove admin role name 'admin' hardcode
status: change-merged

Files placed on repository:
openstack-dashboard-ubuntu-theme_2014.1.3-fuel5.1.2~mira6_all.deb
openstack-dashboard_2014.1.3-fuel5.1.2~mira6_all.deb
python-django-horizon_2014.1.3-fuel5.1.2~mira6_all.deb
python-django-openstack_2014.1.3-fuel5.1.2~mira6_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.2-stable/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/2090
project: packages/centos6/python-django-openstack-auth
branch: 5.1.2
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: change-merged

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira3.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1.2-stable/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-django-openstack-auth has been built for project packages/precise/python-django-openstack-auth
Package version == 1.1.7, package release == ubuntu3

Changeset: https://review.fuel-infra.org/2089
project: packages/precise/python-django-openstack-auth
branch: 5.1.2
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: change-merged

Files placed on repository:
python-openstack-auth_1.1.7-ubuntu3_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.2-stable/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package python-django-openstack-auth has been built for project packages/centos6/python-django-openstack-auth
Package version == 1.1.7, package release == 1

Changeset: https://review.fuel-infra.org/2288
project: packages/centos6/python-django-openstack-auth
branch: master
author: Alex Khivin
committer: Alex Khivin
subject: Patch: \"Remove admin role name 'admin' hardcode in User.is_superuser()\" https://review.openstack.org/#/c/123745/
status: patchset-created

Files placed on repository:
python-django-openstack-auth-1.1.7-1.mira2.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-master-2288/centos

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/8137

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote :

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/9459

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Change abandoned by Timur Sufiev <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/8137
Reason: Fixed in a different CR https://review.fuel-infra.org/#/c/9459/

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/9459
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: eef757580e05b2884e533f2d8c013ab0016dd689
Author: Paul Karikh <email address hidden>
Date: Fri Jul 17 10:50:47 2015

Remove admin role name 'admin' hardcode

Because of hardcoding name as the 'admin' was impossible to
use administrative panel with a custom administrative role name.
This fix replaces hardcoding the name of the administrative role
with RBAC policy check.

DocImpact
Related commit: https://review.openstack.org/#/c/123745/
Partial-Bug: #1371161

Change-Id: Id880763dd0befff921cf99a751d298b3feaf89e0

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-8.0/liberty)

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/13360

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/13896

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (stable/kilo)

Change abandoned by Paul Karikh <email address hidden> on branch: stable/kilo
Review: https://review.fuel-infra.org/13896
Reason: Made by mistake.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-8.0/liberty)

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/13898

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (openstack-ci/fuel-8.0/liberty)

Change abandoned by Paul Karikh <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/13360

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-8.0/liberty)

Reviewed: https://review.fuel-infra.org/13898
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: 2ee8824c45815e0f1398879de228a5acd1cff20d
Author: Paul Karikh <email address hidden>
Date: Tue Nov 24 11:28:39 2015

Remove admin role name 'admin' hardcode

Because of hardcoding name as the 'admin' was impossible to
use administrative panel with a custom administrative role name.
This fix replaces hardcoding the name of the administrative role
with RBAC policy check.

DocImpact
Related commit: https://review.openstack.org/#/c/123745/
Partial-Bug: #1371161

Change-Id: Ide1172469f80397057f51616a465ea8b8996a3db

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (9.0/mitaka)

Fix proposed to branch: 9.0/mitaka
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/18478

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (9.0/mitaka)

Reviewed: https://review.fuel-infra.org/18478
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: ee5eb12f4f95d44358d5ec83c353fe1fc1b00133
Author: Paul Karikh <email address hidden>
Date: Thu Mar 31 12:37:44 2016

Remove admin role name 'admin' hardcode

Because of hardcoding name as the 'admin' was impossible to
use administrative panel with a custom administrative role name.
This fix replaces hardcoding the name of the administrative role
with RBAC policy check.

DocImpact
Related commit: https://review.openstack.org/#/c/123745/
Partial-Bug: #1371161

Change-Id: Ide1172469f80397057f51616a465ea8b8996a3db

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (11.0/ocata)

Fix proposed to branch: 11.0/ocata
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/34211

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (mcp/newton)

Fix proposed to branch: mcp/newton
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/34237

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (mcp/ocata)

Fix proposed to branch: mcp/ocata
Change author: Paul Karikh <email address hidden>
Review: https://review.fuel-infra.org/34882

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (11.0/ocata)

Change abandoned by Ihor Kalnytskyi <email address hidden> on branch: 11.0/ocata
Review: https://review.fuel-infra.org/34211
Reason: 11.0/ocata is obsolete. We use mcp/ocata instead.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (mcp/ocata)

Change abandoned by Ivan Kolodyazhny <email address hidden> on branch: mcp/ocata
Review: https://review.fuel-infra.org/34882
Reason: We dont' need it because of Ic7200dfdf403b63ef3210750617ae102b15c02c8 is merged

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/horizon (mcp/newton)

Change abandoned by Michael Dovgal <email address hidden> on branch: mcp/newton
Review: https://review.fuel-infra.org/34237
Reason: already merged Ic7200dfdf403b63ef3210750617ae102b15c02c8

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.