Mirantis OpenStack

Status code 308 missed in the tuple redirects for keystoneauth session

  1. Series 10.0.x
  2. Bug #1610914
Bug #1610914 reported by Mikhail Samoylov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Status tracked in 10.0.x
10.0.x
Fix Committed
Medium
MOS Keystone
Mirantis OpenStack 10.0
9.x
Won't Fix
Medium
MOS Keystone
Mirantis OpenStack 9.x-updates
keystoneauth
Fix Released
Medium
Alexander Makarov

Bug Description

We need to add 308 status code here.
https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L211
It must be like this:
_REDIRECT_STATUSES = (301, 302, 303, 305, 307, 308)

Mikhail Samoylov (msamoylov)
Changed in fuel:
importance: Undecided → High
Mikhail Samoylov (msamoylov)
Changed in fuel:
assignee: MOS Keystone (mos-keystone) → nobody
Revision history for this message
Boris Bobrov (bbobrov) wrote :

Why? Is there a project in OpenStack that returns 308?

Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Yes, fuel. You can see it in affected projects.

Revision history for this message
Aleksei Stepanov (penguinolog) wrote :

https://tools.ietf.org/html/rfc7238 - 308 is PERMANENT REDIRECT code, so it's should present in redirect

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystoneauth (master)

Fix proposed to branch: master
Review: https://review.openstack.org/352343

Changed in keystoneauth:
assignee: nobody → Alexey Stepanov (astepanov-m)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in keystoneauth:
assignee: Alexey Stepanov (astepanov-m) → Boris Bobrov (bbobrov)
Revision history for this message
Boris Bobrov (bbobrov) wrote :

Oh, nice, Alexey Stepanov was the first. I will abandon my patch now.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystoneauth (master)

Change abandoned by Boris Bobrov (<email address hidden>) on branch: master
Review: https://review.openstack.org/352346
Reason: Being fixed in https://review.openstack.org/#/c/352343/

Boris Bobrov (bbobrov)
Changed in keystoneauth:
assignee: Boris Bobrov (bbobrov) → nobody
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: nobody → MOS Keystone (mos-keystone)
no longer affects: fuel
Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

Mikhail, could you please elaborate on this? What is the impact, should it be backported to the stable branches, et cetera?

Changed in mos:
status: New → Incomplete
assignee: nobody → Mikhail Samoylov (msamoylov)
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

I think that backport not needed. Impact - medium. We have some tests and api handlers in fuel-qa that retrurned status code 308 as response.

Changed in mos:
importance: Undecided → Medium
assignee: Mikhail Samoylov (msamoylov) → MOS Keystone (mos-keystone)
status: Incomplete → Confirmed
OpenStack Infra (hudson-openstack)
Changed in keystoneauth:
assignee: nobody → Alexander Makarov (amakarov)
Denis Meltsaykin (dmeltsaykin)
Changed in mos:
milestone: none → 9.1
OpenStack Infra (hudson-openstack)
Changed in keystoneauth:
assignee: Alexander Makarov (amakarov) → Steve Martinelli (stevemar)
Steve Martinelli (stevemar)
Changed in keystoneauth:
assignee: Steve Martinelli (stevemar) → Alexander Makarov (amakarov)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/352343
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=837118393c9930d0f627783f15df67a4299d5271
Submitter: Jenkins
Branch: master

commit 837118393c9930d0f627783f15df67a4299d5271
Author: Alexey Stepanov <email address hidden>
Date: Mon Aug 8 13:56:13 2016 +0300

    add status code 308 to _REDIRECT_STATUSES

    add status code 308 to _REDIRECT_STATUSES as designed by rfc7238
    Closes-bug: 1610914

    Change-Id: I81ce137dad07e76a0f0c227dc8b263eec64fff7a

Changed in keystoneauth:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/keystoneauth 2.11.1

This issue was fixed in the openstack/keystoneauth 2.11.1 release.

Revision history for this message
Dmitry Mescheryakov (dmitrymex) wrote :

The fix referenced above made it into Newton, hence the issue is fixed in 10.0. Since the issue has medium priority, we will not backport it to 9.x.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.