The login shell of a "nova" user is set to /bin/false

[Anatolii Neliubin]

Detailed bug description:
  The login shell of a user "nova" is set to /bin/false which does not allow "nova" user to login to compute nodes.

Steps to reproduce:
 There is a presumption that the problem was caused by this patch: https://review.fuel-infra.org/#/c/27730/
Expected results:
  User "nova" should be able to login to compute nodes
Workaround:
 Executing "usermod -s /bin/bash nova" command on all compute nodes
Impact:
  Disables resizing of nova VMs:
2017-07-24 13:37:13.278 2194674 ERROR oslo_messaging.rpc.dispatcher ResizeError: Resize error: not able to execute ssh command: Unexpected error while running command.
2017-07-24 13:37:13.278 2194674 ERROR oslo_messaging.rpc.dispatcher Command: ssh 192.168.0.41 mkdir -p /var/lib/nova/instances/1dc08dcc-2448-4fee-a98e-05de8605933a
2017-07-24 13:37:13.278 2194674 ERROR oslo_messaging.rpc.dispatcher Exit code: 1

Description of the environment:
MOS 8.0 MU4

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Alexey Stupnikov <email address hidden>
Review: https://review.fuel-infra.org/36431

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/36431
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: f764db54ea01e03ec4e41da7c6776a892d54216b
Author: Alexey Stupnikov <email address hidden>
Date: Thu Sep 7 16:10:55 2017

Fix shell creation for nova user

For some reason pkgos_adduser was changed during its backport from
openstack-pkg-tools in change #27730 (change-ID
I83f8e22af94c331483077b5ae2aa2038d3f8a967).

As a result, a /bin/false shell was configured for nova user
instead of /bin/bash. I don't know the reasons behind this change,
so just added shell argument and explicitly specified /bin/bash.

Change-Id: I6badd2e529c69b64bd706cfe5b7fb8a4ad389552
Closes-bug: #1706300

[Vladimir Jigulin (vjigulin)]

Verified on 8+mu6updates

root@node-3:/usr/share/doc/nova-common# zcat changelog.Debian.gz | grep 1706300 -B1
  * Fix user creation algorythm. This change effectively fixes bug
    https://launchpad.net/bugs/1706300
root@node-3:/usr/share/doc/nova-common# cat /etc/passwd|grep nova
nova:x:107:114::/var/lib/nova:/bin/bash