VNC console does not work after update to 0.6.1

Bug #1688218 reported by Roman Podoliaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Committed
High
Unassigned

Bug Description

VNC consoles stopped working after we merged https://review.fuel-infra.org/#/c/32522/

The problem is that one of the JS requirements (shipped with noVNC itself) is missing:

[pid 10430] 08:23:32.791068 recvfrom(6, "GET /include/inflator.js HTTP/1.1\r\nHost: openstack.cloudvps.com:6080\r\nX-Real-IP: 194.213.110.82\r\nX-Forwarded-For: 194.213.110.82\r\nX-Forwarded-Proto: https\r\nX-Forwarded-Host: openstack.cloudvps.com:6080\r\nX-Forwarded-Server: openstack.cloudvps.com\r\nX-Forwarded-Port: 6080\r\nConnection: upgrade\r\nUser-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36\r\nAccept: */*\r\nReferer: https://openstack.cloudvps.com:6080/vnc_auto.html?token=c544bf76-6257-49d3-85fb-bca4e07f179c&title=bgp-1(01dd4d46-4bd6-4b42-9ffe-94cdf70cdbc7)\r\nAccept-Encoding: gzip, deflate, sdch, br\r\nAccept-Language: en-US,en;q=0.8,uk;q=0.6,ru;q=0.4\r\nCookie: _ga=GA1.2.945367699.1492610680; login_region=\"http://identity.internal.openstack.cloudvps.com:5000/v3\"; sessionid=07rsjjb7rgeylqkcjh9x25wchbj1j8um; login_domain=; token=110e77fa-e5d2-48f9-b328-eaa9bb4169ce; csrftoken=RoEWImX4xnXg32o5kD6Gihf4Rhi5WoMh\r\n\r\n", 1024, MSG_PEEK, NULL, NULL) = 946
[pid 10430] 08:23:32.791610 recvfrom(6, "GET /include/inflator.js HTTP/1.1\r\nHost: openstack.cloudvps.com:6080\r\nX-Real-IP: 194.213.110.82\r\nX-Forwarded-For: 194.213.110.82\r\nX-Forwarded-Proto: https\r\nX-Forwarded-Host: openstack.cloudvps.com:6080\r\nX-Forwarded-Server: openstack.cloudvps.com\r\nX-Forwarded-Port: 6080\r\nConnection: upgrade\r\nUser-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36\r\nAccept: */*\r\nReferer: https://openstack.cloudvps.com:6080/vnc_auto.html?token=c544bf76-6257-49d3-85fb-bca4e07f179c&title=bgp-1(01dd4d46-4bd6-4b42-9ffe-94cdf70cdbc7)\r\nAccept-Encoding: gzip, deflate, sdch, br\r\nAccept-Language: en-US,en;q=0.8,uk;q=0.6,ru;q=0.4\r\nCookie: _ga=GA1.2.945367699.1492610680; login_region=\"http://identity.internal.openstack.cloudvps.com:5000/v3\"; sessionid=07rsjjb7rgeylqkcjh9x25wchbj1j8um; login_domain=; token=110e77fa-e5d2-48f9-b328-eaa9bb4169ce; csrftoken=RoEWImX4xnXg32o5kD6Gihf4Rhi5WoMh\r\n\r\n", 8192, 0, NULL, NULL) = 946
[pid 10430] 08:23:32.792270 getcwd("/usr/share/novnc", 1024) = 17
[pid 10430] 08:23:32.792357 stat("/usr/share/novnc/include/inflator.js", 0x7ffcd3598160) = -1 ENOENT (No such file or directory)
[pid 10430] 08:23:32.792445 open("/usr/share/novnc/include/inflator.js", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid 10430] 08:23:32.792556 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118, ...}) = 0
[pid 10430] 08:23:32.792662 write(2, "10.170.0.32 - - [04/May/2017 08:23:32] code 404, message File not found\n", 72) = 72
[pid 10430] 08:23:32.792852 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118, ...}) = 0
[pid 10430] 08:23:32.792915 write(2, "10.170.0.32 - - [04/May/2017 08:23:32] \"GET /include/inflator.js HTTP/1.1\" 404 -\n", 81) = 81
[pid 10430] 08:23:32.793072 sendto(6, "HTTP/1.1 404 File not found\r\n", 29, 0, NULL, 0) = 29
[pid 10430] 08:23:32.793176 sendto(6, "Server: WebSockify Python/2.7.6\r\n", 33, 0, NULL, 0) = 33
[pid 10430] 08:23:32.793267 sendto(6, "Date: Thu, 04 May 2017 08:23:32 GMT\r\n", 37, 0, NULL, 0) = 37
[pid 10430] 08:23:32.793310 sendto(6, "Content-Type: text/html\r\n", 25, 0, NULL, 0) = 25
[pid 10430] 08:23:32.793341 sendto(6, "Connection: close\r\n", 19, 0, NULL, 0) = 19
[pid 10430] 08:23:32.793376 sendto(6, "\r\n", 2, 0, NULL, 0) = 2
[pid 10430] 08:23:32.793438 sendto(6, "<head>\n<title>Error response</title>\n</head>\n<body>\n<h1>Error response</h1>\n<p>Error code 404.\n<p>Message: File not found.\n<p>Error code explanation: 404 = Nothing matches the given URI.\n</body>\n", 195, 0, NULL, 0) = 195
[pid 10430] 08:23:32.793576 exit_group(0) = ?
[pid 10430] 08:23:32.795199 +++ exited with 0 +++

thus, novncproxy returns 404 and the console can not be opened in a browser.

We need to update the package spec to include all the files from: https://github.com/novnc/noVNC/tree/v0.6.1/include

Changed in mos:
milestone: none → 10.0
tags: added: area-packaging
Changed in mos:
status: New → Confirmed
description: updated
no longer affects: mos/9.x
description: updated
Changed in mos:
importance: Undecided → High
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/xenial/novnc (master)

Fix proposed to branch: master
Change author: Roman Podoliaka <email address hidden>
Review: https://review.fuel-infra.org/35175

Changed in mos:
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/xenial/novnc (master)

Reviewed: https://review.fuel-infra.org/35175
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: fde204cbfaa0569313fb7b151d71c22640b7e5e5
Author: Roman Podoliaka <email address hidden>
Date: Fri May 5 09:54:37 2017

Package all the includes of noVNC

A few dependencies were added in the newer releases of noVNC, make
sure we package them properly. Right now missing inflator.js leads
to 404 returned by novncproxy on an attempt to open a VNC console
in Horizon.

Related-Bug: #1666562
Closes-Bug: #1688218

Change-Id: Icb3fa2c7c672f9a9e873e9d7cc3f71234e2b9e8a

Changed in mos:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.