qemu-img calls need to be restricted by ulimit (CVE-2015-5162)

[Roman Podoliaka]

Upstream bug: https://bugs.launchpad.net/ossa/+bug/1449062

Reported via private E-mail from Richard W.M. Jones.

Turns out qemu image parser is not hardened against malicious input and can be abused to allocated an arbitrary amount of memory and/or dump a lot of information when used with "--output=json".

The solution seems to be: limit qemu-img ressource using ulimit.

Example of abuse:

-- afl1.img --

$ /usr/bin/time qemu-img info afl1.img
image: afl1.img
[...]
0.13user 0.19system 0:00.36elapsed 92%CPU (0avgtext+0avgdata 642416maxresident)k
0inputs+0outputs (0major+156927minor)pagefaults 0swaps

The original image is 516 bytes, but it causes qemu-img to allocate 640 MB.

-- afl2.img --

$ qemu-img info --output=json afl2.img | wc -l
589843

This is a 200K image which causes qemu-img info to output half a
million lines of JSON (14 MB of JSON).

Glance runs the --output=json variant of the command.

-- afl3.img --

$ /usr/bin/time qemu-img info afl3.img
image: afl3.img
[...]
0.09user 0.35system 0:00.47elapsed 94%CPU (0avgtext+0avgdata 1262388maxresident)k
0inputs+0outputs (0major+311994minor)pagefaults 0swaps

qemu-img allocates 1.3 GB (actually, a bit more if you play with
ulimit -v). It appears that you could change it to allocate
arbitrarily large amounts of RAM.

[Roman Podoliaka (rpodolyaka)]

Setting the importance according to the upstream bug.

[Denis Meltsaykin (dmeltsaykin)]

Closing as Won't Fix for 8.0 as this is a medium importance non-customer-found bug.

[Alexey Shtokolov (ashtokolov)]

Fixed in stable/mitaka https://review.openstack.org/#/c/326327/

[Dmitry Belyaninov (dbelyaninov)]

Verified on snapshot #430
It is impossible to boot instance from malicious qemu-img