[Murano] Environment deployment fails with exceptions.TypeError: getDefaultRouter() takes exactly 2 arguments (1 given)

Bug #1513497 reported by Anastasia Kuznetsova
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Critical
Nikolay Starodubtsev

Bug Description

Note: this issue reproduced only on MOS 7.0 MU1 and not reproduced on MOS 7.0 vanilla.

Steps to reproduce:
1. Deploy environment with Murano based on MOS 7.0
2. Manually update all nodes by using 7.0-mu1
3. Create Murano environment, do not select existing network
4. Add any application to the env and send it to deploy

Observed result:
Deployment failed with:
2015-11-05 13:01:57.752 9011 DEBUG murano.dsl.executor [-] 4683cea5e4e84833b49c187389de4c1c: End execution: io.murano.Environment.deploy (5110862244198178525) with exception [exceptions.TypeError]: getDefaultRouter() takes exactly 2 arguments (1 given) _invoke_method_implementation /usr/lib/python2.7/dist-packages/murano/dsl/executor.py:156
2015-11-05 13:01:57.754 9011 ERROR murano.common.engine [-]
  exceptions.TypeError: getDefaultRouter() takes exactly 2 arguments (1 given)
  Traceback (most recent call last):
    File "/tmp/murano-packages-cache/ef7c79bf-328d-4ce0-b52b-5fd2842e64c9/io.murano/Classes/Environment.yaml", line 74:9 in method deploy of class io.murano.Environment
        $.applications.pselect($.deploy())
    File "/tmp/murano-packages-cache/ef7c79bf-328d-4ce0-b52b-5fd2842e64c9/io.murano.apps.docker.DockerStandaloneHost/Classes/DockerStandaloneHost.yaml", line 64:13 in method deploy of class io.murano.apps.docker.DockerStandaloneHost
        $.instance.deploy()
    File "/tmp/murano-packages-cache/ef7c79bf-328d-4ce0-b52b-5fd2842e64c9/io.murano/Classes/resources/Instance.yaml", line 89:9 in method deploy of class io.murano.resources.Instance
        $.ensureNetworksDeployed()
    File "/tmp/murano-packages-cache/ef7c79bf-328d-4ce0-b52b-5fd2842e64c9/io.murano/Classes/resources/Instance.yaml", line 159:13 in method ensureNetworksDeployed of class io.murano.resources.Instance
        $.environment.defaultNetworks.environment.deploy()
    File "/tmp/murano-packages-cache/ef7c79bf-328d-4ce0-b52b-5fd2842e64c9/io.murano/Classes/resources/NeutronNetwork.yaml", line 56:37 in method deploy of class io.murano.resources.NeutronNetwork
        $._netExplorer.getDefaultRouter()
    File "/usr/lib/python2.7/dist-packages/retrying.py", line 68 in method wrapped_f
        return Retrying(*dargs, **dkw).call(f, *args, **kw)
    File "/usr/lib/python2.7/dist-packages/retrying.py", line 223 in method call
        return attempt.get(self._wrap_exception)
    File "/usr/lib/python2.7/dist-packages/retrying.py", line 261 in method get
        six.reraise(self.value[0], self.value[1], self.value[2])
    File "/usr/lib/python2.7/dist-packages/retrying.py", line 217 in method call
        attempt = Attempt(fn(*args, **kwargs), attempt_number, False)

Tags: murano
Changed in mos:
status: New → Confirmed
description: updated
Changed in mos:
assignee: MOS Murano (mos-murano) → Nikolay Starodubtsev (starodubcevna)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/murano (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Nikolay Starodubtsev <email address hidden>
Review: https://review.fuel-infra.org/13684

Changed in mos:
status: Confirmed → In Progress
Changed in mos:
milestone: 7.0-updates → 7.0-mu-1
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/murano (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/13684
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: e938f735a08eae499c456118ceef616e5317b810
Author: Nikolay Starodubtsev <email address hidden>
Date: Fri Nov 6 09:41:15 2015

Correct wrong decoration of getDefautRouter method

The error occured because MuranoPL executor couldn't get right method
signature. In this patch we created internal _getDefaultRouter method to
decorate it with retries and then take it back to original getDefaultRouter
function.

Change-Id: I2bc41588571fea7591999a179ffd4da726bae39c
Closes-Bug: #1513497

Changed in mos:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

Steps to verify:
1) update env and make sure that all needed changes are presented on every controller
2) create Murano environment and DO NOT select existing network for it.
3) Add any application to it and send environment to deploy
4) Check that environment deployment finished without any errors.

Changed in mos:
status: Fix Committed → Fix Released
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/murano (openstack-ci/fuel-8.0/liberty)

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Nikolay Starodubtsev <email address hidden>
Review: https://review.fuel-infra.org/14087

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/murano (openstack-ci/fuel-8.0/liberty)

Change abandoned by Nikolay Starodubtsev <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/14087

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.