Two column modal forms are broken in Ubuntu Horizon

Bug #1399148 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Committed
High
Thomas Goirand

Bug Description

Among broken forms are Create Image/Create Volume. Workflows (Create Instance) and non-modal two-column forms (User Settings) are not affected. Only Horizon on Ubuntu is affected, CentOS is okay.

Tags: horizon
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :
Changed in mos:
milestone: none → 6.0
status: New → Confirmed
Timur Sufiev (tsufiev-x)
summary: - Two column modal forms are broken in Horizon
+ Two column modal forms are broken in Ubuntu Horizon
description: updated
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

The bug is caused by the Ubuntu using python-xstatic-bootstrap-scss_3.1.1.1-1, while CentOS uses XStatic-Bootstrap-SCSS-3.2.0.0. These 2 versions differ at least by the value of $modal-inline-padding which is 20px for Ubuntu (older package) instead of 15px for CentOS (newer package) - which is in turn causing 2-column modal forms to break. Bumping to next version because changing the version of Bootstrap package can have a major impact on UI appearance and we have to verify that it works and looks fine.

Changed in mos:
milestone: 6.0 → 6.1
status: Confirmed → In Progress
assignee: Timur Sufiev (tsufiev-x) → Max Yatsenko (myatsenko)
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Max Yatsenko will build a new Bootstrap xstatic package for Ubuntu.

Timur Sufiev (tsufiev-x)
tags: added: horizon
Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Hi.

The xstatic-bootstrap-scss is comming from Debian. So it's up to me to work on that. I would appreciate if you could keep me in the loop. I'll be upgrading the package right away now in Debian.

Cheers,

Thomas

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Thomas, sure, thank you for being vigilant :). Then we'll wait until you update this package and then change horizon specs to use it.

Changed in mos:
assignee: Max Yatsenko (myatsenko) → Thomas Goirand (thomas-goirand)
Revision history for this message
Dmitry Mescheryakov (dmitrymex) wrote :

The broken UI really sucks, lets try and fix it in 6.0

Changed in mos:
milestone: 6.1 → 6.0
Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-xstatic-bootstrap-scss has been built for project packages/precise/python-xstatic-bootstrap-scss
Package version == 3.1.1.1, package release == ubuntu2

Changeset: https://review.fuel-infra.org/1263
project: packages/precise/python-xstatic-bootstrap-scss
branch: 6.0
author: Max Yatsenko
committer: Max Yatsenko
subject: Build xstatic-bootstrap-scss-3.2.0.0 package
status: patchset-created

Files placed on repository:
python-xstatic-bootstrap-scss_3.1.1.1-ubuntu2_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1263/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-xstatic-bootstrap-scss has been built for project packages/precise/python-xstatic-bootstrap-scss
Package version == 3.2.0.0, package release == ubuntu2

Changeset: https://review.fuel-infra.org/1263
project: packages/precise/python-xstatic-bootstrap-scss
branch: 6.0
author: Max Yatsenko
committer: Max Yatsenko
subject: Build xstatic-bootstrap-scss-3.2.0.0 package
status: patchset-created

Files placed on repository:
python-xstatic-bootstrap-scss_3.2.0.0-ubuntu2_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1263/ubuntu

Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Hi,

I have uploaded python-xstatic-boostrap-scss 3.2.0.1-1 to Debian Sid, and the packages for Wheezy are here:
http://juno-wheezy.pkgs.mirantis.com/debian/pool/wheezy-juno-backports/main/p/python-xstatic-bootstrap-scss/

The ones for Trusty here:
http://juno-trusty.pkgs.mirantis.com/debian/pool/trusty-juno-backports/main/p/python-xstatic-bootstrap-scss/

Cheers,

Thomas

Timur Sufiev (tsufiev-x)
Changed in mos:
status: In Progress → Fix Committed
Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package python-xstatic-bootstrap-scss has been built for project packages/precise/python-xstatic-bootstrap-scss
Package version == 3.2.0.0, package release == ubuntu2

Changeset: https://review.fuel-infra.org/1263
project: packages/precise/python-xstatic-bootstrap-scss
branch: 6.0
author: Max Yatsenko
committer: Max Yatsenko
subject: Build xstatic-bootstrap-scss-3.2.0.0 package
status: change-merged

Files placed on repository:
python-xstatic-bootstrap-scss_3.2.0.0-ubuntu2_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable/ubuntu

Revision history for this message
Dmitry Mescheryakov (dmitrymex) wrote :

The fix is not in mirrors yet. Hence the bug is not in 'fix committed' state yet.

Changed in mos:
status: Fix Committed → Won't Fix
status: Won't Fix → In Progress
Changed in mos:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.