elisa.core.pattern_matcher.PatternMatcher matches things it shouldn't

[Guillaume Emont]

The match should do exact match, and not search.

Example code that fails:

from elisa.core.pattern_matcher import PatternMatcher, MatchNotFound

def do_test():
    result = False
    matcher = PatternMatcher()
    matcher.add_pattern("foo", False)
    try:
        result = matcher.match("foobar")
    except MatchNotFound:
        result = True

    return result

Expected behaviour: do_test() returns True.
Current behaviour: do_test() returns False.

To Verify:
1) Install elisa
2) run trial.py elisa-core\elisa\core\tests\test_pattern_matcher.py
3) test_no_wide_match, passes

[Guillaume Emont (guijemont)]

I need to fix this to be able to do #232574 (DVD).

[Michał Sawicz (saviq)]

Guillaume, are you sure that's how it is?

Based on the code attached if matcher.match throws MatchNotFound you catch the exception, set result to True and return it...

Isn't that why it returns True?

[Guillaume Emont (guijemont)]

I'm pretty sure. The expected behaviour is that match() throws MatchNotFound in that case.
Here's a more clever and simpler version of the test:

def do_test():
    matcher = PatternMatcher()
    matcher.add_pattern("foo", False)
    try:
        matcher.match("foobar")
    except MatchNotFound:
        return True

    return False