Moonshot-Webp doesn't provision the rules & services in the keyring

[Stefan Paetow]

I have an identity as below:

<identities><identity>
<display-name>Moonshot @ Cardiff</display-name>
<user>blah</user>
<password>whatever</password>
<realm>whatever.com</realm>
<selection-rules>
<rule><pattern>host/*.cf.ac.uk</pattern>
<always-confirm>false</always-confirm>
</selection-rules>
</identity></identities>

When I use moonshot-webp with the -f switch, the pattern is imported correctly into identities.txt. However, when I use moonshot-webp without the switch to import it into the keyring, the pattern is not imported, i.e. it does not show up in the view in Seahorse (the GNOME Keyring viewer in RedHat).

The pattern should show up, no?

[Sam Hartman (hartmans)]

Are you running with DISPLAY set in a session with the keyring unlocked?

[Stefan Paetow (stefan-paetow)]

Yup!

[Stefan Paetow (stefan-paetow)]

The identity is added in the keyring (and shows up in the Moonshot ID selector), but the keyring doesn't show the pattern. :-/

[Sam Hartman (hartmans)]

OK, when we've tried that it's worked fine.

[Sam Hartman (hartmans)]

And the program hangs?
Hmm.

[Stefan Paetow (stefan-paetow)]

No, in this case the program does not hang. I've just rebooted the workstation in question just in case DBus was stuck.

Running Moonshot-webp displays the same behaviour as reported. Identity is imported, but the pattern is not. The Rules-Pattern entry in the keyring entry for this identity is blank.

[Kevin Wasserman (krwasserman)]

Using moonshot.exe and moonshot-webp.exe just built on debian from the tip of master, I tried the example verbatim and got "could not parse, invalid content" from moonshot-webp. I then added the missing </rule>, re-ran and added the card successfully. In Seahorse, I see "Rules-Pattern: host/*.cf.ac.uk" as expected.

[Kevin Wasserman (krwasserman)]

Is it possible you have multiple "Moonshot @ Cardiff ..." identities with slightly different nai? If you already had an identity "Moonshot @ Cardiff" with a different nai, when you add this card, it should rename the newly added card to "Moonshot @ Cardiff 0" and the pattern would be visible under that card. Or there's something platform-specific going on.

[Stefan Paetow (stefan-paetow)]

No, I don't.

And although the description is missing the closing </rule> tag, the file on the VM (I was retyping it because of a drag and drop issue) does actually contain the closing tag (it was a copy of the moonshot.msht file in /usr/share/moonshot-ui/).

It is possible that your fix for the default identity possibly resolved this?

[Stefan Paetow (stefan-paetow)]

Platform-specific issues are also a possibility, yes... I'm testing with CentOS 6.5.

[Kevin Wasserman (krwasserman)]

No, I don't believe the fix for the "No Identity" update hang could be related to this. I'll try it out on Centos.

[Stefan Paetow (stefan-paetow)]

Ok... If possible... can you spin an RPM for me that I can install? I'll be happy to try it again with new code ;-)

[Stefan Paetow (stefan-paetow)]

Ok, even with the new code, a completely fresh ID selector (with no IDs in the keyring) will not import a pattern for No Identity (or any other) with Moonshot-Webp.

I think that's what you expected on #11.

But yes, problem still there on CentOS 6.5.

[Kevin Wasserman (krwasserman)]

Occurs only on Centos; most likely the old vala array property bug.

[Kevin Wasserman (krwasserman)]

Fixed in commits:
883bf1bc0d10f9814306f77abcd7e0556e886d09
9f09eafa92b92dd094691ef159117f3f3b9bf69e
3070990ebff578c309fd53126aa9d1c252ce2d95

[Stefan Paetow (stefan-paetow)]

Thanks, Kevin. I'll try to confirm as fixed as soon as I have an updated RPM to test. :-)