Importing blank identity uses username and realm from previously imported identity

Bug #1430980 reported by Stefan Paetow on 2015-03-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Moonshot ID Selector
Low
Dan Breslau

Bug Description

When trying to use 'moonshot-webp' to change the services or patterns of the 'No Identity' identity, it causes moonshot-webp to hang/crash/die:

1. Moonshot-webp prompts whether I would like to update the ID card 'No Identity' using nai '@'. So far so good.
2. I click Yes in the dialog
3. Moonshot-webp appears to hang until DBus times out with the error: "Error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken."
4. The dialog never closes. It just sits there.
5. I click the x in the corner. A prompt labelled 'Metacity' says: "is not responding. You may choose to wait a short while longer or force the application to quit".

So, I'm guessing that Moonshot UI will not let this happen because:

a) Moonshot UI enforces 'non-blank' constraints on Issuer (Realm) and Username, and that gets stuck, or,
b) You're not supposed to fiddle with the 'No Identity' identity.

Suggestions include:

a) A switch similar to -f that allows us to modify the 'No Identity' identity's rules and patterns (but not the username, realm, password, etc).
b) Not use a switch at all and simply just update the 'No Identity' identity's rules and patterns if username and realm are empty.
c) A switch that will disable the checks...

description: updated
description: updated
Changed in moonshot-ui:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Kevin Wasserman (krwasserman)
Kevin Wasserman (krwasserman) wrote :

Fix committed in bf2c1886b... No new commandline options required.

Changed in moonshot-ui:
status: Confirmed → Fix Committed
Stefan Paetow (stefan-paetow) wrote :

It no longer hangs. Hooray!

However, if you previously imported another identity, importing a blank identity will populate the blank username and realm with the username and realm of the previous import. That shouldn't happen either.

1. Create a MSHT file with a dummy identity.
2. Import it.
3. Import your blank identity.
4. Check the ID manager (or Seahorse).
5. You should now have a new 'No Identity x' (where x is a number).

Killing all instances of 'moonshot' (killall -9 moonshot in the terminal for the invoking user) resolves that problem.

This is with the latest build of this.

Stefan Paetow (stefan-paetow) wrote :

Should've mentioned step 5:

5. You should now have a new 'No Identity x' (where x is a number), with username and realm the same as the identity imported in Step 2.

Mark Donnelly (meadmaker) wrote :

In testing with the latest release (0.9.6.1), Dan discovered that he can't reproduce this. (However... I did get an assertion failure, which did not lead to a crash, when I tried to import an identity. I will look into this.)

Changed in moonshot-ui:
importance: High → Medium
summary: - Cannot change patterns or hosts in 'No Identity' identity
+ Importing blank identity uses username and realm from previously
+ imported identity
Changed in moonshot-ui:
status: Fix Committed → Confirmed
Margaret Cullen (mrw42) on 2017-04-28
Changed in moonshot-ui:
assignee: Kevin Wasserman (krwasserman) → Dan Breslau (dbreslau)
Dan Breslau (dbreslau) wrote :

I've checked in a fix for the assertion error that I reported above.

As for the original problem, I'm still unable to reproduce it. However, I discovered that the behavior is different depending on whether I use the "Import" button on the Moonshot UI, or the moonshot-webp command line. The UI import adds an identity named "No Identity 0", with the services that were assigned to it in the import file. In contrast, moonshot-webp silently discards the empty identity.

Margaret Cullen (mrw42) wrote :

Arguably, you should be able to do this with moonshot-webp. Keeping this around at low priority unless/until it affects an actual customer.

Changed in moonshot-ui:
importance: Medium → Low
Margaret Cullen (mrw42) on 2018-05-11
Changed in moonshot-ui:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers