trust_router reads editor auto-save files as config files

[Sam Hartman]

Emacs someties creates .#file when editing file. So trust_router finds .#portal.cfg after I edit portal.cfg sometimes. It does not parse as a config file and wouldn't be desirable to parse even if it did.

[Mark Donnelly (meadmaker)]

I would generalize this to say that the trust router should ignore any dot-files.

[Sam Hartman (hartmans)]

>>>>> "Mark" == Mark Donnelly <email address hidden> writes:

    Mark> I would generalize this to say that the trust router should
    Mark> ignore any dot-files.

At least in Debian and Ubuntu, a lot of thought has gone into the
problem of figuring out what files to ignore in configuration
directories.
The behavior of run-parts with the --lsbsysinit option seems to be our
best guess after several years working on this:

       If neither the --lsbsysinit option nor the --regex option is
       given then
              the names must consist entirely of ASCII upper- and
       lower-case letters,
              ASCII digits, ASCII underscores, and ASCII minus-hyphens.

                     If the --lsbsysinit option is given, then the
                     names must not end in
                            .dpkg-old or .dpkg-dist or .dpkg-new or
                     .dpkg-tmp, and must belong to
                            one or more of the following namespaces:
                     the LANANA-assigned namespace
                            (^[a-z0-9]+$); the LSB hierarchical
                     and reserved namespaces
                            (^_?([a-z0-9_.]+-)+[a-z0-9]+$); and the
                     Debian cron script namespace
                            (^[a-zA-Z0-9_-]+$).

There may be some RPM suffixes to exclude as well.

[Adam Bishop (adam-omega)]

RPM will create *.rpmnew and *.rpmsave filesas appropriate - both should be ignored.

[Jennifer Richards (jennifer-k)]

What is the desired behavior?

I have a fix that follows the run-parts --lsbsysinit convention Sam quoted, with ".cfg" added to the end of the namespaces described. (That requirement implicitly avoids files with the .dpkg-* and .rpm* suffixes.)

This is a somewhat restrictive naming convention---e.g., capital letters are excluded except in the Debian cron script namespace. Is that ok or desirable? It'd be easy enough to do a simpler check in the same spirit. E.g., restricting the first character to an alphanumeric or underscore.

Can someone with a better sense for how these are named in practice offer a suggestion?

[Stefan Paetow (stefan-paetow)]

Is it prudent to simply ignore dot-files?

[Jennifer Richards (jennifer-k)]

Certainly that is the simplest approach that eliminates the original bug.

[Jennifer Richards (jennifer-k)]

For now, I'm making the minimal change that resolves this bug report (rejecting config files that begin with an ASCII '.' character). Existing behavior already avoids reading config files with various package manager-specific extensions.

[Jennifer Richards (jennifer-k)]

Fix committed (commit 1e1cb0013d476900080a556bc1ba3c0b1ddfaa33).