Smoke test fails and is not under ci or within openstack review process

Bug #1636508 reported by David Charles Kennedy
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Monasca
New
High
Unassigned

Bug Description

The devstack plugin for monasca-api by default deploys a smoke test that I have found to fail. The code deployed for the test is not within openstack, is not pulled with a specific revision, does not get reviewed in gerrit and is not tested through ci in order to gate changes.

This means that an uncontrolled source of change can cause the monasca-api devstack plugin to fail. The tests should be removed from the plugin or at least set to default non-inclusion pending some fixup of the situation - versioning/ci within openstack or at least pulling a specific revision which would then not change.

The offending code is at 1686-1732 though the crux of the matter is the downloading of a tarball not fixed by revision (which would at least ensure consistency) - at line 1695 of monasca-api/devstack/plugin.sh.

Changed in monasca:
importance: Undecided → High
Revision history for this message
Joseph Davis (joseph-a-davis) wrote :

I think the offending tests have been removed - when I look on the master branch of monasca-api/devstack/plugin.sh, the file is now only 1387 lines long. Can you verify so we can close this bug?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.