The behavior of the changing page button for the lists(alarm definitions, alarms and notifications) should be improved.

Bug #1486508 reported by Sayako Kondo
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Monasca
Fix Released
Undecided
Shinya Kawabata

Bug Description

At this moment, the changing page button of Alarm Definitions/Alarms/Notifications list works as below.
 - If there are 10 or more items(Alarm Definitions or Alarms or Notifications) in the list,
   the "Next Page" button is displayed.
 - We can see next page when clicking the "Next Page" button.

The "Previous Page" button doesn't exist. So we cannot back to the previous page.
The "Previous Page" button should be added.

Additionally, the "Next Page" button appears when the list have just 10 items.
So if clicking the "Next Page" button, there are no items in next page.
The "Next Page" button should be appeared when the list have 11 or more items.

Allan G (greental)
Changed in monasca:
status: New → Triaged
Revision history for this message
Shinya Kawabata (s-kawabata) wrote :

I think this is pagination problem.
Current implementation using django.core.paginator but it doesn't use normally.
It's hybrid that django.core.paginator and original implementaiton.

So I think adopting django.core.paginator normally is to solve the problem easily.
But this way has a problem.
Whenever press the next(previous) page button,
It loads the whole Items(Alarm Definitions/Alarms/Notifications).
So if items are many, performance problem will occur.

What do you think?

Changed in monasca:
assignee: nobody → Shinya Kawabata (s-kawabata)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to monasca-ui (master)

Reviewed: https://review.openstack.org/261153
Committed: https://git.openstack.org/cgit/openstack/monasca-ui/commit/?id=6faa22ce865e10aad4223210573d19b13519db86
Submitter: Jenkins
Branch: master

commit 6faa22ce865e10aad4223210573d19b13519db86
Author: Shinya Kawabata <email address hidden>
Date: Thu Dec 24 13:55:28 2015 +0900

    Enhance changing page button of list in monasca-ui

    Add "Previous Page" button.
    Fix "Next Page" button behavior when list has just multiples of ten.

    Change-Id: Ibc05b05f8d2a728e4051b1b49e4a9c73be13471b
    Closes-Bug: #1486508

Changed in monasca:
status: Triaged → Fix Released
Revision history for this message
Bradley Klein (brad-klein) wrote :

can we reopen this bug? the alarm page has the fix, but not alarm history?

Changed in monasca:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to monasca-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/266205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to monasca-ui (master)

Reviewed: https://review.openstack.org/266205
Committed: https://git.openstack.org/cgit/openstack/monasca-ui/commit/?id=d25b5f4cb3ae6e7ba816b11f03688aa886c46f42
Submitter: Jenkins
Branch: master

commit d25b5f4cb3ae6e7ba816b11f03688aa886c46f42
Author: Shinya Kawabata <email address hidden>
Date: Tue Jan 12 14:47:52 2016 +0900

    Enhance changing page button of list in monasca-ui

    Adding missed page - Alarm Histroy

    Change-Id: I7e3e93ede35e03d1a7ac8055fbc2db6f0d7e2cd0
    Reference: Ibc05b05f8d2a728e4051b1b49e4a9c73be13471b
    Closes-Bug: #1486508

Changed in monasca:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.