nagios-check falsely claims "Nagios not installed, or no nagios checks found"

[Paul Collins]

On one of my CI jobs, nagios-check failed as follows:

2020-03-20 02:22:49 [ERROR] Nagios not installed, or no nagios checks found on ubuntu-mirror/1
2020-03-20 02:22:49 [ERROR] Nagios not installed, or no nagios checks found on ubuntu-mirror/0

I worked through the Nagios checks and they all exist and work, although not all of the succeed.

I checked the Mojo code, and the above is triggered by this:

        if 'No such file or directory' in output or 'sudo: unknown user: nagios' in output:
            error_output = "Nagios not installed, or no nagios checks found on {}".format(unit)

and having reviewed my checks' output, it was triggered by this:

ubuntu@juju-270af5-archive-servers-9-0:~$ /srv/ubuntu-mirror/bin/check-updates.sh archive.ubuntu.com /srv/ftp.root/ubuntu/.trace/ubuntu-juju-270af5-archive-servers-9-0
stat: cannot stat '/srv/ftp.root/ubuntu/.trace/ubuntu-juju-270af5-archive-servers-9-0': No such file or directory

I suggest the following:

 * include "output" when reporting a problem
 * separate the conditions above, and report them separately
 * tighten up or change the "No such file or directory" check to problem it's intended to disagnose

[Paul Collins (pjdc)]

Briefly assigned and unassigned, but the problem I just ran into is a different one with the same symptom.

[Paul Collins (pjdc)]

Well, I ended up working on this anyway. Linked branch should improve matters.