Mojo chokes on buggy/undefined nagios checks

Bug #1803030 reported by Barry Price
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mojo: Continuous Delivery for Juju
Fix Committed
Low
Barry Price

Bug Description

Obviously they shouldn't exist in the first place, but Mojo doesn't cope well if a buggy charm has left half-defined check definitions on disk, e.g.:

command[check_haproxy_queue]=

This results in Mojo crashing with:

bash: line 7: syntax error near unexpected token `&&'
bash: line 7: `(set -x; && echo MOJO_NAGIOS_OK) || echo MOJO_NAGIOS_FAIL '

The linked MP should exclude any undefined/empty checks.

Related branches

Barry Price (barryprice)
Changed in mojo:
assignee: nobody → Barry Price (barryprice)
status: New → In Progress
importance: Undecided → Medium
importance: Medium → Low
Revision history for this message
Junien F (axino) wrote :

I think it's good that Mojo chokes on these, it helps us identify charm bugs.

Revision history for this message
Barry Price (barryprice) wrote :

I think it's reasonable to inform the user about the issue, rather than crashing without an explanation.

As per MP, will rework to print a friendlier error in this situation.

Barry Price (barryprice)
Changed in mojo:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.