deploy apply-config-changes=True fails with boolean values

[Haw Loeung]

Hi,

This is a variation of LP:1633442 where apply-config-changes fails with charm options that are booleans. Traceback below:

| ERROR option "debug" expected boolean, got "None"
| 2018-03-29 02:08:45 [ERROR] Error calling external process
| Traceback (most recent call last):
| File "/usr/lib/python2.7/dist-packages/mojo/cli.py", line 628, in run_with_args
| args.func(args)
| File "/usr/lib/python2.7/dist-packages/mojo/utils.py", line 305, in wrapped
| return method(*args, **kwargs)
| File "/usr/lib/python2.7/dist-packages/mojo/cli.py", line 346, in run_from_manifest
| manifest.run(project, workspace, args.stage)
| File "/usr/lib/python2.7/dist-packages/mojo/manifest.py", line 97, in run
| auto_secrets=auto_secrets)
| File "/usr/lib/python2.7/dist-packages/mojo/phase.py", line 900, in run
| diff_processor=lambda d: process_config_changes_from_diff(
| File "/usr/lib/python2.7/dist-packages/mojo/phase.py", line 784, in diff
| diff_processor(diff)
| File "/usr/lib/python2.7/dist-packages/mojo/phase.py", line 901, in <lambda>
| d, preview=False),
| File "/usr/lib/python2.7/dist-packages/mojo/phase.py", line 536, in process_config_changes_from_diff
| subprocess.check_call(juju_set_command)
| File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
| raise CalledProcessError(retcode, cmd)
| CalledProcessError: Command '['juju', 'config', 'nrpe', 'lacp_bonds=None', 'xfs_errors=None', 'users=-w 20 -c 25', 'dont_blame_nrpe=None', 'netlinks=None', 'zombies=-w 3 -c 6 -s Z', 'debug=None', 'conntrack=None', 'swap_activity=None']' returned non-zero exit status 1

From the above, and the config options for the nrpe charm[1], both "debug" and "dont_blame_nrpe" are booleans.

This is with mojo 0.5.0.

[1]https://jujucharms.com/nrpe/

[Paul Collins (pjdc)]

Those "None" values are odd, and may indicate that the option should in fact not be set at all?

[Haw Loeung (hloeung)]

I think those options should still be set though. So if a config option was previously "True" and now changed to "False", mojo should still update it to "False" to match what's in the spec.

(Sorry, I'm probably a bit late)