Builddeps' repo_keys look for .gpg files in the wrong place
Bug #1539754 reported by
Caio Begotti
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mojo: Continuous Delivery for Juju |
Opinion
|
Wishlist
|
Unassigned | ||
Bug Description
Mojo 0.2 looks for .gpg files in the workspace spec_dir instead of, ideally, looking at the local dir of the workspace. If it keeps looking in the spec dir that means we would have to commit the PPAs keys in our spec branches, which is far from ideal. Even so, Mojo appends the stage name to that lookup, which just makes it worse. Expecting .gpg keys to be local secrets that need to be pulled during a secrets phase seems saner.
I think https:/
Related branches
lp:~caio1982/mojo/local_repo_keys
- Tom Haddon: Needs Fixing
-
Diff: 37 lines (+5/-4)2 files modifieddocs/mojo/readme.md (+4/-2)
mojo/phase.py (+1/-2)
Revision history for this message
| Tom Haddon (mthaddon) wrote | #1 |
| Changed in mojo: | |
| status: | New → Opinion |
| importance: | Undecided → Wishlist |
To post a comment you must log in.
I don't agree that committing gpg keys to the spec is a problem. They're not secrets and are not something that is going to change depending on where you're deploying from.
I agree that where to put them needs to be better documented and could optionally be in a different location within the spec but that's slightly different to the intent of this bug.