MoinMoin

PATCH: MoinMoin generates invalid headers when MIME encoding

Bug #348960 reported by Matthias Andree on 2009-03-26

This bug affects 1 person

Affects		Status	Importance	Assigned to
	MoinMoin	New	Undecided	Unassigned
	moin (Ubuntu)	Fix Released	Low	Unassigned
Nominated for Hardy by Matthias Andree
Nominated for Intrepid by Matthias Andree
Nominated for Jaunty by Matthias Andree

Bug Description

If MoinMoin is configured to send e-mail messages, and for instance uses this:

mail_from = u"Ex-Ample-Wiki <email address hidden>"

the resulting header is as follows, confusing several clients (for instance, Opera 9.64):

From: =?UTF-8?Q?Ex-Ample-Wiki_?=<email address hidden>

but it should be (note that we no longer encode the blank that separates the encoded word from the opening angle bracket):

From: =?UTF-8?Q?Ex-Ample-Wiki?= <email address hidden>

Please apply the attached patch to MoinMoin/mail/util.py (version 1.5.8, as found on Ubuntu 8.04 LTS Server). Later MoinMoin versions moved the affected method around, for instance to MoinMoin/mail/sendmail.py (version 1.8.2).

The upstream bug report is at http://moinmo.in/MoinMoinBugs/EmailShouldNotMIMEEncodeBlanks

In Ubuntu 8.04, the affected package is python-moinmoin 1.5.8-5.1ubuntu2.2

See original description

Related branches

lp:ubuntu/natty/moin

Matthias Andree (matthias-andree) on 2009-03-26

description:

updated

Matthias Andree (matthias-andree) on 2009-03-26

description:

updated

Revision history for this message

Matthias Andree (matthias-andree) wrote on 2009-03-27:

improved fix with suggestion from ThomasWaldmann (in the moinmo.in wiki) Edit (774 bytes, text/plain)

Alessio Treglia (quadrispro) on 2009-03-28

Changed in moin (Ubuntu):
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-04-07:

This bug was fixed in the package moin - 1.8.2-2ubuntu1

---------------
moin (1.8.2-2ubuntu1) jaunty; urgency=low

  * Merge from debian unstable (LP: #350287), Ubuntu remaining changes:
    - Remove python-xml from Recommends field, the package isn't anymore in
      sys.path.
  * debian/patches/10002_encodeAddress_fix_MIME_spacing.patch:
    - Headers are malformed in notification email when, in mail_from, there is
      a phrase before the angle address that gets encoded.
      Thanks to Matthias Andree for the patch (LP: #348960).
  * debian/rules:
    - Add --install-layout=deb option to install everything in /usr instead of
      /usr/local, fix FTBFS.

moin (1.8.2-2) unstable; urgency=low

  [ Jonas Smedegaard ]
  * Update debian/copyright (Bump years, merge equally licensed and
    authored files.
  * Update copyright hints.
  * Refer to …/README.Debian(.gz) (not just …/README.Debian), and limit
    note to max. 72 chars per line. Closes: bug#516123, thanks to Brent
    Clark.

[ Frank Lin PIAT ]
* Use systemwide copy of fckeditor Closes: bug#452599

moin (1.8.2-1) unstable; urgency=low

* New upstream release.

-- Alessio Treglia <email address hidden> Sat, 28 Mar 2009 14:36:56 +0100