OOPS when trying to login using openid from a page that contains spaces in the URL

Bug #338228 reported by Ursula Junque on 2009-03-05
Affects Status Importance Assigned to Milestone
Moin OpenID module
Rowan Kerr

Bug Description

Steps to reproduce:
1) Go to a wiki that uses openid, wiki.ubuntu.com, for instance
2) Being logged out, try to access a page that contains spaces in the URL, e.g. https://wiki.ubuntu.com/Artwork/Incoming/Jaunty/Kxx Wallpaper
3) It should show a message: "OpenID error: None.", won't login and will produce the OOPS:

MalformedReturnURL: None

Also: OOPS-1159C1049

Related branches

Ursula Junque (ursinha) on 2009-03-05
description: updated
Francis J. Lacoste (flacoste) wrote :

This is a bug on the moin side. It's not encoding the return_url properly.

James Henstridge (jamesh) wrote :

So the Moin plugin will need fixing for login to work in this case.

The best Launchpad can do here is to report the error gracefully.

Francis J. Lacoste (flacoste) wrote :

It also doesn't encode URLs with accented characters in them: OOPS-1161C910

Changed in moin-openid:
importance: Undecided → High
status: New → Triaged
importance: High → Medium
Joey Stanford (joey) on 2009-03-12
Changed in moin-openid:
assignee: nobody → rowan
Rowan Kerr (rowan) wrote :

The Moin path needed to be escaped when the continuation url was created. It wasn't being taken care of farther down the chain in either Moin or the Python OpenID libs.

Rowan Kerr (rowan) on 2009-03-18
Changed in moin-openid:
status: Triaged → In Progress
Rowan Kerr (rowan) wrote :

Linked my new branch which includes fix above.

Rowan Kerr (rowan) on 2009-04-17
Changed in moin-openid:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers