hicolor icon theme not gnome compliant

[Kyle Nitzsche]

1) install pcmanfm (a lightweight file manager)
2) it launches indicating the current icon theme is not valid
3) switch the current icon theme to "gnome" by setting gconf key /dekstop/gnome/interface/icon_theme to "gnome"
4) relaunch pcmanfm - there's no error

Apparently the hicolor icon theme (in /usr/share/icons/) isn't a valid gnome icon theme for some reason, perhaps because it lacks some required icons?

[Kyle Nitzsche (knitzsche)]

Tony, please raise this with Intel on Thursday.

[Bob Spencer (bob-spencer)]

Probably what is happening is that there is no theme selected for icons by default. The hicolor theme isn't something we created. It is used as the default fall-back for icons when the icon theme doesn't contain the requested icon. Given that pcmanfm is complaining, it probably can't find its icons in the fallback. How about we set the gnome icon theme as the default.

[Adrian_Hung (adrian-hung)]

Hello, I am Adrian Hung from Compal. If we set the gnome icon theme as default, I was concerned if there will be any side effect in hildon-desktop and mobile-basic-flash. Since both of them will load some icons from default icon themes. Thanks!

[Pat McGowan (pat-mcgowan)]

is this really an issue in a final product configuration?

[Eva_Hsu (eva-hsu)]

on pcmanfm-0.3.2.2/src/main.c has a function to check icon theme,
if mark this function => check_icon_theme() , the error message “GTK+ icon theme is not properly” will not pop up.

[Pat McGowan (pat-mcgowan)]

assign to kyle

[Eva_Hsu (eva-hsu)]

Add following functions to pcmanfm-0.3.2.2/src/main.c => static void check_icon_theme()

static void check_icon_theme()
{
    GtkSettings * settings;
    char* theme;
    const char* title = N_( "GTK+ icon theme is not properly set" );
    const char* error_msg =
     ..................
    settings = gtk_settings_get_default();

/*****Set "gtk-icon-theme-name" to "gnome" ****/
g_object_set( settings, "gtk-icon-theme-name","gnome", NULL );

/****Get icon theme from settings*******/
g_object_get( settings, "gtk-icon-theme-name", &theme, NULL );

    /* No icon theme available */
    if ( !theme || !*theme || 0 == strcmp( theme, "hicolor" ) )
       ..............
}

then it can switch icon theme from hicolor to gnome.

[elvafu (elva-fu)]

assign to m11

[Kyle Nitzsche (knitzsche)]

I just installed pcmanfm_0.3.2.2-2_lpia.deb and I get the same pop-up indicating the icon theme is not valid.

[Kyle Nitzsche (knitzsche)]

My mistake, I thought you had made these changes in the source.

We made a local workaround in pcmanfm for this bug. We hide the pop-up and everything works fine. Therefore this is a low priority/no priority bug for me.

[Kyle Nitzsche (knitzsche)]

marking as wishlist since our pcmanfm, hack works. I still tend to think, as Bob Spencer said, the default icon theme should be valid. It is now "Human", which doesn't exist in /usr/share/icons.

[Bob Spencer (bob-spencer)]

Kyle Nitzsche wrote:
> marking as wishlist since our pcmanfm, hack works. I still tend to
> think, as Bob Spencer said, the default icon theme should be valid.
> It is now "Human", which doesn't exist in /usr/share/icons.

Todd changed the default icon theme to be "gnome" in the latest version
of moblin-applets. No "Human" theme should exist now.

>
> ** Changed in: acton
> Importance: High => Wishlist

[Tony Espy (awe)]

Changed to "Fix Committed", as Todd has checked in a fix to the latest version of moblin-applets, per Bob's comment.

We should consider pulling in this change for RC2.