Starting Touchscreen banner still exists when do nothing after launch touch screen till time out or exit calibration by ESC

[cathyli]

Description:
------------------------
Starting Touchscreen banner still exists when do nothing after launch touch screen till time out or exit calibration by ESC. Found the issue in moblin-applet 0.52, and player 0.1.0.8 in QA 20080407 RC1 image .

Reproduced steps:
---------------------------
1. Launch touch screen from Preferences category.
2. After it prompt up calibration window, do nothing and wait for timeout.
3. Launch touch screen from Preferences category.
4. After it prompt up calibration window, press key "ESC" to exit calibration.

Current results:
-------------------------
In step2&4, calibration window exit, but it always shows "Starting Touchscreen..." banner. It confused user that the system is launching touch screen.

Expected results:
-------------------------
In step2&4, calibration window should exit and not show "Starting Touchscreen..." banner.

Root Cause analysis:
-------------------------
It seems it doesn't deal with timeout correctly. Should remove "Starting Touchscreen..." banner when timeout or exit unexpectedly.

[ToddBrandt (todd-e-brandt)]

ok, the problem is this, the touchscreen calibration code we inherited and that has never had troubles on samsung only looks at these five options in the xorg.conf file: MinX, MaxX, MinY, MaxY, and Rotate. The config on the crown beach apparantly adds in two rare, but valid options: SwapX and SwapY.

Let me illustrate, this is the functional config that Yang sent me (inside the touchscreen device section):

Option "MinX" "28"
Option "MinY" "46"
Option "MaxX" "991"
Option "MaxY" "954"
Option "SwapX" "1"
Option "SwapY" "1"

What this means is that the MinX, MaxX, MinY, and MaxY values look orientated typically, but the SwapX and SwapY options mean that both X and Y are actually inverted. Thus, the following should be an identical config (subtracting the two swap options):

Option "MinX" "991"
Option "MinY" "954"
Option "MaxX" "28"
Option "MaxY" "46"

Since the current touchscreen calibrator doesn't even look at the swap options, it puts the data in backwards. This is why it produces a good config when the buttons are pressed in reverse order.

Great catch Yang! I'll add a fix for 0.53 this evening.

[ToddBrandt (todd-e-brandt)]

fix committed in 0.53. I changed the behavior of the calibrator to always leave the min and max values in logical order (i.e. MaxX > MinX and MaxY > MinY) and to employ the use of SwapX and SwapY to handle inverted axes. The read_calibration and apply_calibration apis both still take five arguments, but instead of the last arg being rotation, it's a "flags" argument with 4 bits used: b0=SwapX, b1=SwapY, b2=RotateCCW, b4=RotateCW. The moblin-dbustest program has also been updated to read in this new data.

[ToddBrandt (todd-e-brandt)]

oops, I accidentally added comments to this one that were intended for https://bugs.launchpad.net/moblin-applets/+bug/199065. This bug is still open and is meant for m11. Sorry for the confusion.

[ToddBrandt (todd-e-brandt)]

This is a bug in mobile-basic-flash. The startup banner doesn't ever timeout, and it's also reliant on a GtkWindow callback which isn't guaranteed to be used. The banner should be shut down when the process ends, not when the window closes. I've reassigned this to Bob Spencer.