The Theme Setting still no function inside the "Setting" application

Bug #206389 reported by Lawrence
10
Affects Status Importance Assigned to Milestone
Moblin Applets
Fix Released
Wishlist
ToddBrandt
Moblin UI Framework
Fix Released
Wishlist
Horace

Bug Description

BISO: 028A
Image: 0313 hardy image
Unit: D0

The Theme Setting still no function inside the "Setting" application??

Changed in acton:
importance: Undecided → Critical
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Have not implemented this feature yet.

Changed in acton:
status: New → Confirmed
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

manual theme switching pegged to beta 1.

Changed in acton:
milestone: none → beta1
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

assign to kyle for beta 2
need support from intel

Changed in acton:
assignee: nobody → kylenitz
importance: Critical → Medium
milestone: beta1 → beta2
Jing Wang (jing-j-wang)
Changed in moblin-applets:
assignee: nobody → horace-li
importance: Undecided → Medium
Horace (horace-li)
Changed in moblin-ui-framework:
status: New → Triaged
Changed in moblin-applets:
assignee: nobody → todd-e-brandt
importance: Undecided → Wishlist
status: New → Confirmed
yanglei (lei-a-yang)
Changed in moblin-ui-framework:
importance: Medium → Wishlist
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Kyle, can this bug be closed?

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

ok, this bug is nearly fixed. The only thing left is that the marquee doesn't seem to propagate theme changes when the gtk_theme key is changed.

Revision history for this message
Adrian_Hung (adrian-hung) wrote :

Hello, I am Adrian Hung from Compal. So, Is theme setting tool GUI launched from falsh UI --> "Setting" --> "Theme" ?
Thanks.

Revision history for this message
Adrian_Hung (adrian-hung) wrote :

Theme setting tool is added in Beta1.5 image. After testing, there are some problems:
(a) Change theme from "Carousel" (default) to "Mobile Basic", background of some icons on status bar becomes white (Launchpad Bug# 225238)
(b) It's still the same theme for marquee when theme changes. (Launchpad Bug# 225235)
(c) Font size in "Carousel" (default) is too small (11.625) and which in "Mobile Basic" is too large (16.75). We think maybe we should stick on font size = 14 and only change feel and look for different themes.

Revision history for this message
Adrian_Hung (adrian-hung) wrote :

After changing theme from "Carousel" (default) to "Mobile Basic", reboot MID and then theme will change back to "Carousel", system doesn't remember the setting of last used theme.

Revision history for this message
Adrian_Hung (adrian-hung) wrote :

After discussion, we decide to set our font size fixed to 11.625 (as defined in default theme, Carousel). Which means that in both themes, we want to use the same font size = 11.625. Thanks a lot!

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Remembering the current theme between boots could be accomplished by rewriting the following two startup files on each theme change:

/etc/X11/Xsession.d/25ume-config-common_startup
/usr/share/ume-config-common/ume-gui-start

Currently these scripts check for the existence of the "carousel" theme, and, if it is present, they set it as the default gtk and matchbox theme.

The theme switcher could rewrite them to look for the user selected theme and, if present, use it.

Revision history for this message
Loïc Minier (lool) wrote :

These are system files; you would need root to change them; it's best to change user files for the ume user instead. We could change the startup to look into new per-user files (e.g. ~ume/.theme), but it would be best to use some standardized technology such as GConf instead.

Revision history for this message
Bill Filler (bfiller) wrote :

agreed. We don't want to be rewriting those files. The current theme is already being stored in gconf so we should figure out how to use those settings.

Revision history for this message
May Xie (may-xie) wrote :

Todd, assign it to m11. What's the status?

Changed in moblin-applets:
milestone: none → m11
Revision history for this message
elvafu (elva-fu) wrote :

assign to m11

Changed in moblin-ui-framework:
milestone: none → m11
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

OK, I found one remaining bug with this in moblin-settings-daemon. Changes to the gtk_theme and icon_theme gconf keys do trigger callbacks in moblin-settings-daemon during runtime which are then propagated to xsettings. However, when the daemon is first started, it doesn't propagate the *initial* gconf key values to xsettings. Therefore a theme change doesn't appear to survive a reboot. The problem was that I inserted code which set the screen resolution/rotation just before the xsettings code, and it returned when the gconf keys for resolution/rotation were both NULL (thus skipping the xsettings code). I've fixed this. The easiest way to verify is as follows:

The nm-applet plugin has an icon on the marquee which changes depending on the type of connection, but it also changes based on the theme. The /desktop/gnome/interface/icon_theme key controls what the base icon set will be for this applet, and the two themes that I switch between to test are Human and hicolor. When you have a wired connection with the Human theme, the icon appears to be two little computer monitors representing a "network". When you have a wired connection with the hicolor theme, the icon appears as the connector at the end of an ethernet cable. You can switch back and forth to see the two icons with the following commands:

NOTE: you must be logged in as user ume: "su ume".
1) gconftool-2 --type "string" --set "/desktop/gnome/interface/icon_theme" "Human"
2) gconftool-2 --type "string" --set "/desktop/gnome/interface/icon_theme" "hicolor"

Now the default for the system is "hicolor", so if no xsettings are propogated at all (i.e. the icon_theme key is ignored), the nm-applet will startup with the hicolor icon. Try setting the theme to Human and rebooting. Prior to 0.62, the icon would still be hicolor, but with 0.63 it should change to Human.

Changed in moblin-applets:
status: Confirmed → Fix Committed
Revision history for this message
cathyli (cathy-li) wrote :

Verified in applets 0.64, try the two commands as user ume:
1) gconftool-2 --type "string" --set "/desktop/gnome/interface/icon_theme" "Human"
2) gconftool-2 --type "string" --set "/desktop/gnome/interface/icon_theme" "hicolor"
network manager icon changed, if change back, need restart xsettings or else the backcolor is white.

Revision history for this message
cathyli (cathy-li) wrote :

Verified in QA image 20080528, theme work well inside the "Setting" applets. Close it.

Changed in moblin-applets:
status: Fix Committed → Fix Released
cathyli (cathy-li)
Changed in moblin-ui-framework:
status: Triaged → Fix Released
Revision history for this message
Tony Espy (awe) wrote :

Per Bill's comments, marking as "FixReleased" ( RC1 ).

Changed in acton:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.