Many buffer overflow vulnerabilities in mmdb_mmcif.cpp

Bug #1566305 reported by Chris Kerr on 2016-04-05
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

In several cases strcpy() or similar is called to copy data read from the input file into a buffer on the stack. This makes stack overflow attacks trivial.

Revision history for this message
Chris Kerr (ckerr-s) wrote :

In general I've noticed that the code uses exclusively C-style memory management rather than taking advantage of RAII and the STL containers. Is there a design reason for this (e.g. maintaining compatibility with old compilers)?

information type: Private Security → Public Security
Revision history for this message
Chris Kerr (ckerr-s) wrote :

I ask because, despite the security issues, mmdb still seems to be the best PDB/CIF parsing library for C and Fortran that I can find, to the extent that refactoring to fix the buffer overflow problems might be easier than getting another library (with its own security issues) to do what I need.

To post a comment you must log in.
This report contains Public Security information  Edit
Everyone can see this security related information.

Other bug subscribers