bpm.tapButton in the common script file is not working correctly

[Sean M. Pappalardo]

bpm.tapButton() in the the common controller script file assumes the "bpm" ControlObject holds the track's native BPM value. Since it no longer does as of 2.0, the algorithm needs adjusting because it currently oscillates pretty badly.

[RJ Skerry-Ryan (rryan)]

Hm, but "bpm" has always been the effective deck BPM (after rate adjustment) while file_bpm is the native / detected BPM.

Shouldn't scripts use the bpm_tap CO anyway?

[Sean M. Pappalardo (pegasus-renegadetech)]

According to the wiki, bpm_tap just changes the BPM value on the track, such as when it's incorrectly detected. bpm.tapButton() is supposed to change the speed of the track (via the rate slider) to match the tapped BPM to synchronize with an external beat.

[Wihola IT (wihola)]

Hi guys. I wanted to map my TAP button, than I saw JS wiki, than I saw examples, than I saw that this is not working as it supposed to work, than I searched in the Internet, and now I am here.

So what gonna happen with the `bpm.tapButton(deck);` in the common scripts? Cuz now it's working way too weird. It sets my BPM to a random value after second tap from 65 to 215.

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/2594

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8434