Shoutcast calls sleep()
Bug #883374 reported by
RJ Skerry-Ryan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
High
|
Tuukka Pasanen | ||
1.10 |
Won't Fix
|
High
|
Unassigned | ||
1.11 |
Won't Fix
|
High
|
Unassigned | ||
1.9 |
Won't Fix
|
High
|
Unassigned |
Bug Description
EngineShoutcast calls sleep(). This blocks the sidechain thread which could cause the sidechain buffers to overflow which could cause a skip in the sidechain output (shoutcast and recording).
Related branches
lp:~mixxxdevelopers/mixxx/fixes_sidechain_refactor
- Mixxx Development Team: Pending requested
- Diff: 0 lines
Changed in mixxx: | |
status: | New → Confirmed |
tags: | added: performance shoutcast |
Changed in mixxx: | |
importance: | Undecided → High |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This looks fun. Any idea why we sleep in those places? The second sleep appears to be waiting for libshout to connect to the server because the shout_open call is async and doesn't provide an update callback (head. broke. keyboard.), but I can't figure out the first sleep call (after it prints the number of failed attempts).