bzr revision not displayed in builds from http://builds.mixxx.org/builds/trunk/

Bug #996574 reported by Daniel Schürmann on 2012-05-08
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Low
RJ Skerry-Ryan
1.11
Low
RJ Skerry-Ryan

Bug Description

Its hard to discover which version Mixxx is currently installed because the bzr revision is not displayed in builds from http://builds.mixxx.org/builds/trunk/
(Not in the GUI and also not in Terminal)

> Debug [Main]: Mixxx 1.11.0-alpha2 "(built on: May 8 2012 @ 03:58:18; flags: hid
> hifieq mad optimize=9 qdebug shoutcast vamp verbose vinylcontrol)" is starting.
> ..

Wy not always display the bzr revision, also in release builds?

RJ Skerry-Ryan (rryan) wrote :

Hm, how do we keep messing this one up? :) which OS is this?

Changed in mixxx:
milestone: none → 1.11.0
Daniel Schürmann (daschuer) wrote :

Hi RJ
I have tested it only on Ubuntu 64 and 32.
It looks like the build server fails to write buid.h

Deleting deprecated build file: /tmp/buildd/mixxx-1.10.1-alpha/src/build.h
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
ERROR: Could not determine branch name from output of 'bzr info'. Please file a bug with the output of 'bzr info' attached.
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".

Didn't we moved the build.h to the temporaty build folder?

I think we must also find a solution for tarball builds.
Can you try to generate the build.h at add it to the tarball?

Thank you,

Daniel

Daniel Schürmann (daschuer) wrote :

Windows build is not effected.

I am working on a solution for tarball builds!

Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
Daniel Schürmann (daschuer) wrote :

here it is:

The patch creates a lastbzrbuild.h in src folder. It is written at build time when bzr is able to collect the revision info.
It is intended to checkin this file. It is used to generate the bzr info when a tarball build is done.

Maybe its al little annoying tat this file will be changed in every check-in. A better solution is to generate a file like this by a server side hook script, but I think hook scripts are not possible in Launchpad.

Another option would be to create such a file just before packing the official tarball. Bit this does not cover the case when downloading a tarball from launchpad.

Additional I have moved the version things to a separate file to save some compile time. Also it was a little frustrating how long it takes for my netbook to compile such a simple class :-(

The original bug seems to be an issue on our buildverver. It looks like the .bzr folder was lost before calling scons.
@RJ: can you have a look, Thank you!

Daniel Schürmann (daschuer) wrote :

Hi RJ,

Ok, my new lastbzrbuild.h is a candidate for continuous conflicts. So this solution is more annoying then it helps for now.
We should consider how we can put this file in our official source package and triag the tracability in case of Launchpad tarball downloads.

I think a scons option, only set by our build server could be a solution.
What do you think?

Kind regards,

Daniel

I agree -- I think the fix should be done on the build server just limited
to the Ubuntu packaging portion of the sconscript. Maybe we can include
build.h when we build the source tarball.

On Sat, Jun 9, 2012 at 11:56 AM, Daniel Schürmann <<email address hidden>
> wrote:

> Hi RJ,
>
> Ok, my new lastbzrbuild.h is a candidate for continuous conflicts. So this
> solution is more annoying then it helps for now.
> We should consider how we can put this file in our official source package
> and triag the tracability in case of Launchpad tarball downloads.
>
> I think a scons option, only set by our build server could be a solution.
> What do you think?
>
> Kind regards,
>
> Daniel
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/996574
>
> Title:
> bzr revision not displayed in builds from
> http://builds.mixxx.org/builds/trunk/
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/996574/+subscriptions
>

Daniel Schürmann (daschuer) wrote :

Hi RJ,
I have no access to the build server scripts.
Will you take care of it or what else can I do?

Changed in mixxx:
milestone: 1.11.0 → none
RJ Skerry-Ryan (rryan) on 2012-09-06
Changed in mixxx:
assignee: Daniel Schürmann (daschuer) → RJ Ryan (rryan)
jus (jus) on 2012-09-11
Changed in mixxx:
importance: Undecided → Low
Daniel Schürmann (daschuer) wrote :

Should be fixed since lp:mixxx/1.11 #3370.
Tested with 1.11.0-beta2-pre (build r3419) on Ubuntu 64 Precise.
Thank you RJ!

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers