BPM Lock Icon
Bug #992811 reported by
RJ Skerry-Ryan
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Low
|
Max Linke |
Bug Description
The new BPM lock feature in 1.11 adds a checkbox next to each BPM in the library table. Currently it's the same checkbox as the played one. It would be better if we had a nice lock icon.
Related branches
lp:~max-linke/mixxx/bpmdelegate
- Daniel Schürmann: Approve
-
Diff: 658 lines (+304/-9)32 files modifiedmixxx/build/depends.py (+2/-0)
mixxx/res/mixxx.qrc (+2/-0)
mixxx/res/skins/Deere1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/Deere1280x800-WXGA/skin.xml (+4/-0)
mixxx/res/skins/Deere1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/Deere1440x900-WXGA+/skin.xml (+3/-0)
mixxx/res/skins/Deere1920x1080-FullHD/skin.xml (+3/-0)
mixxx/res/skins/Deere1920x1200-WUXGA/skin.xml (+3/-0)
mixxx/res/skins/DeereSamplegrid1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/Phoney1600x1200-UXGA/skin.xml (+3/-0)
mixxx/res/skins/Phoney1680x1050-WSXGA/skin.xml (+3/-0)
mixxx/res/skins/PhoneyDark1600x1200-UXGA/skin.xml (+3/-0)
mixxx/res/skins/PhoneyDark1680x1050-WSXGA/skin.xml (+3/-0)
mixxx/res/skins/Shade1024x600-Netbook/skin.xml (+3/-0)
mixxx/res/skins/Shade1024x768-XGA/skin.xml (+3/-0)
mixxx/res/skins/ShadeDark1024x600-Netbook/skin.xml (+3/-0)
mixxx/res/skins/ShadeDark1024x768-XGA/skin.xml (+3/-0)
mixxx/src/library/basesqltablemodel.cpp (+3/-0)
mixxx/src/library/bpmdelegate.cpp (+75/-0)
mixxx/src/library/bpmdelegate.h (+39/-0)
mixxx/src/library/bpmeditor.cpp (+63/-0)
mixxx/src/library/bpmeditor.h (+33/-0)
mixxx/src/library/stardelegate.cpp (+0/-6)
mixxx/src/library/starrating.cpp (+1/-1)
mixxx/src/skin/legacyskinparser.cpp (+6/-1)
mixxx/src/widget/wtracktableview.cpp (+16/-1)
Changed in mixxx: | |
milestone: | none → 1.11.0 |
assignee: | nobody → jus (jus) |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in mixxx: | |
milestone: | 1.11.0 → 1.11.1 |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
milestone: | 1.11.1 → 1.12.0 |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I need a little help with this one please. WXGA/skin. xml ) all checkbox are the same, but we want to have separate icons for played/bpm lock/whatever column. :indicator { width: 12px; height: 12px;} :indicator: checked { background: url(skin: /foo.png) ;} :indicator: unchecked { background: url(skin: /foo.png) ;}
With the current code (e.g. around line 2138 in Deere1280x800-
QTableView:
QTableView:
QTableView:
I tried to specify an ID Selector with no luck. It should match all QTableView instances whose object name is LIBRARYTABLE_ BPM_LOCK. I can work with LIBRARYTABLE_ BPM_LOCK, can i? LIBRARYTABLE_ BPM_LOCK: :indicator { width: 12px; height: 12px;} LIBRARYTABLE_ BPM_LOCK: :indicator: checked { background: url(skin: /foo.png) ;} LIBRARYTABLE_ BPM_LOCK: :indicator: unchecked { background: url(skin: /foo.png) ;}
QTableView#
QTableView#
QTableView#