"load tracks into playing decks" doesn't work

Bug #986532 reported by Florian Mahlknecht
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Florian Mahlknecht

Bug Description

Even if I activate "load tracks into playing decks" in the settings, I still can't load tracks into playing decks.
In my opinion a check-box would be more intuitive in this case. On the other hand, someone might wants to add an option like "only if the volume is turned down, load the track into a playing deck".

I guess the information about my operating system is useless in this case.

(sorry for my bad English)

Revision history for this message
jus (jus) wrote :

What version of Mixxx you're running and what is your operating system?

At least with Mixxx 1.10 & latest lp:mixxx on MacOSX 10.6.8 i can not confirm this bug. It just loads as it should into playing decks if the option is activated.

Revision history for this message
Florian Mahlknecht (florian-mahlknecht-95) wrote :

I built the 1.11.0 alpha (lp:mixxx) on Ubuntu 11.10 32-bit.

Revision history for this message
Florian Mahlknecht (florian-mahlknecht-95) wrote :

I've fixed it now!

The problem was, that the entering drag was ignored: wwaveformviewer.cpp:165 and woveriew.cpp:491
I added a private member variable m_pConfig* to these classes to get the required information. Then I changed the initializations in skinparser.cpp. On linux it works. But i don't know if there's a better solution or if the problem occurs only on linux.

To compile it on ubuntu with the GCC, i had to add the following options: -msse -mmmx -msse2
See http://www.linuxquestions.org/questions/ubuntu-63/using-xmmintrin-h-in-ubuntu-707942/

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Florian,

Thank you for the patch.
I can confirm the bug itself and I can confirm that you patch looks good and solves the problem.
I have the same system installed as yours.

I have also noticed that the context menu from the track tables disables the "load to a playing deck" entry as well.
We should consider, if this is a similar bug.

You are right that the default "scons" command will fail. But it should work with:
scons optimize=2

This issue is tracked in Bug #887741.
If you can confirm that the patch from bug Bug #887741 re-enable compiling without your patch and command:
scons optimize=0
You should remove the depend.py part from your patch.

(Please note that scons caches the command line options from previous calls)

Changed in mixxx:
status: New → In Progress
assignee: nobody → Florian Mahlknecht (florian-mahlknecht-95)
jus (jus)
Changed in mixxx:
importance: Undecided → Low
milestone: none → 1.11.0
Revision history for this message
Florian Mahlknecht (florian-mahlknecht-95) wrote :

Hi,

I'm sorry, I didn't see the Bug #887741. With the patch "depends2.patch" it compiles fine using "scons optimize=0".
Yes, you're right: in the context menu occurs the same error. I've fixed that as well.

It should work.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks Florian! Could you please sign the Mixxx contributor agreement here:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0

Also, is it ok to credit you as "Florian Mahlknecht"?

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Florian Mahlknecht (florian-mahlknecht-95) wrote :

My pleasure!
Oh thanks, "Florian Mahlknecht" is great :)

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6374

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.