Set log with cue point export

Bug #963464 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Daniel Schürmann

Bug Description

As requested by Jus in https://code.launchpad.net/~daschuer/mixxx/features_setlog/+merge/78882/comments/173015,
the attached patch against lp:mixxx 2994 introduces an additional database column pl_datetime_added.

This is used to generate the cue point in readable text export and a timestamp in set log view and cvs exort.

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

The patch looks good but won't this also export times when a playlist is exported? The times may not even make sense if you've re-ordered your playlist.

Can you add a boolean to the export method that you flip to output times only when exporting from SetLogFeature?

Changed in mixxx:
milestone: none → 1.11.0
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Ok, now the cuepoints are only added to setlog playlists.

The attached patch is against lp:mixxx #2995

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good except for one thing:

Could you add to the ALTER TABLE schema statement:

DEFAULT DATETIME('now')

That way older versions of Mixxx that use a DB with schema version 15 won't fail to add songs to playlists b/c they didn't provide the pl_datetime_added column. (Otherwise you would need to change the min_compatible version of the schema).

Go ahead and commit this to trunk once you've done that :).

Revision history for this message
Daniel Schürmann (daschuer) wrote :

A non constant default is not possible with ALTER TABLE and sqlite.
I have tested MIxxx 1.10 with the new schema and it woks anyway.

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 963464] Re: Set log with cue point export

Ah I see -- oh well. It's good that older versions just leave the column
empty on insert.

2012/3/28 Daniel Schürmann <email address hidden>

> A non constant default is not possible with ALTER TABLE and sqlite.
> I have tested MIxxx 1.10 with the new schema and it woks anyway.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/963464
>
> Title:
> Set log with cue point export
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/963464/+subscriptions
>

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6331

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.