Better error messages for schema upgrade

Bug #963408 reported by Daniel Schürmann on 2012-03-23
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Schürmann

Bug Description

If the schema.xml is outdated, the following error messages appears:

"
Unable to upgrade your database schema to version x.
Your mixxx.db file may be corrupt.
Try renaming it and restarting Mixxx.
"

This is confusing because the mixxx.db is actual in a fine state.

The attached patch against lp:mixxx #2994 gives following message in this case:

Unable to upgrade your database schema to version x
Your <path to schema.xml> file may be outdated.

Daniel Schürmann (daschuer) wrote :
Changed in mixxx:
status: New → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
jus (jus) wrote :

Agree, the current error message is not helpful. But is the new one really better? We should provide a solution to the user if possible.

Is there is a helpful wiki/manual page we can link to? If not how would a solution to this error look like?

Changed in mixxx:
importance: Undecided → Low
Daniel Schürmann (daschuer) wrote :

Hi jus,

the patch is better because it distinguishes the two cases:

Unable to upgrade your database schema to version x.
Your mixxx.db file may be corrupt.
Try renaming it and restarting Mixxx.

and

Unable to upgrade your database schema to version x
Your schema.xml file may be outdated.

I agree, it would be even better to add a wiki link for both cases.

RJ Skerry-Ryan (rryan) on 2012-04-30
Changed in mixxx:
milestone: none → 1.11.0
Daniel Schürmann (daschuer) wrote :

Updated patch with a third case, missing or invalid schema file.

RJ Skerry-Ryan (rryan) wrote :

The patch looks good but I'm wary of updating the strings this late on such an important error message. I'd almost rather have a properly translated bad error message than English good error messages. What do you think?

Hi RJ,

I understand your concerns.
But I am sure there must be only a petty minority of our users which are
not able to figured out what this untranslated error message means.
This error message will usually not appear, but if, than the original
translated message is totally misleading in some cases.

2012/6/21 RJ Ryan <email address hidden>

> The patch looks good but I'm wary of updating the strings this late on
> such an important error message. I'd almost rather have a properly
> translated bad error message than English good error messages. What do
> you think?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/963408
>
> Title:
> Better error messages for schema upgrade
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> If the schema.xml is outdated, the following error messages appears:
>
> "
> Unable to upgrade your database schema to version x.
> Your mixxx.db file may be corrupt.
> Try renaming it and restarting Mixxx.
> "
>
> This is confusing because the mixxx.db is actual in a fine state.
>
> The attached patch against lp:mixxx #2994 gives following message in
> this case:
>
> Unable to upgrade your database schema to version x
> Your <path to schema.xml> file may be outdated.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/963408/+subscriptions
>

jus (jus) wrote :

The goal is to provide assistance to the user in case the error occurs which the current message certainly does not - translated or not. Imo it is better to have a correct error message in english than to have a nicely translated but incorrect error message in the local language. +1 for inclusion in 1.11.

RJ Skerry-Ryan (rryan) wrote :

Sounds good to me -- patch committed. Thanks!

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers