Can't change the language inside Mixxx

Bug #952709 reported by Albert Santoni
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Tom Gascoigne

Bug Description

It's not uncommon for users to run an operating system with a different locale than what they'd actually prefer Mixxx to be in. In other words, you may not want Mixxx to be in the same language as the rest of your OS.

For these users, we should offer an option to change the language in the preferences. (It's OK if we have to ask the user to restart the program.)

For bonus points, you could implement dynamically changing the language:
http://doc.trolltech.com/qq/qq08-swedish-chef-sequel.html#dynamic
http://www.fioniasoftware.dk/blog/?p=75

Tags: easy i18n
Albert Santoni (gamegod)
description: updated
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

FYI for anyone that might see this, there is currently a command-line option (in 1.10.0 and above) that lets you do this.
--locale de for example

Revision history for this message
Tom Gascoigne (tgascoigne) wrote :

I've come up with a quick solution in this patch. It adds a combo box to the Interface preferences menu with all the available locales, and stores the selection in [Config] Locale.
Curiously, on my machine, the QLocale(QString name) constructor fails to resolve to a proper locale for 3 of the locales, so 'C' is returned instead. Namely 'eo', 'ia', and 'lb'. Does this happen for anyone else?

Tom

Changed in mixxx:
assignee: nobody → Tom Gascoigne (tgascoigne)
Revision history for this message
jus (jus) wrote :

Thanks for the patch. I tried on MacOS and 'C' is returned instead for 'eo', 'ia', and 'lb' . Other than that it works fine. Might be a QT issue, cause another qt app (Clementine player) display the same faulty locale strings.

Maybe we could add a 'system default' to the drop down menue that is selected by default. By now i had the first entry 'Arabic' selected per default while my system is 'en'. The interface was 'en' though.

Changed in mixxx:
milestone: none → 1.11.0
status: Confirmed → In Progress
Revision history for this message
Tom Gascoigne (tgascoigne) wrote :

Thanks for the feedback. Is it best we hide the locales that don't resolve properly from the list completely, or leave those in?

Tom

Revision history for this message
mutil (mutil) wrote :

Hey Tom,
Your patch doesn't work with latest trunk, could you please update it?

Revision history for this message
Tom Gascoigne (tgascoigne) wrote :

Hi mutil,

Certainly, here is an up to date patch with a 'System' option added as suggested above. I've also made it so that locales that fail to resolve correctly (display as 'C' in the drop-down) are not shown.

Regards,
Tom Gascoigne

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks a lot Tom! I've committed your patch to trunk and it will be released in 1.11.0. Is it ok to credit you as "Tom Gascoigne"?

Could you sign the MIxxx developer agreement? This gives us permission to distribute your changes with Mixxx:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0

tags: added: i18n
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Tom Gascoigne (tgascoigne) wrote :

Brilliant :) Yes, Tom Gascoigne is fine, and I've signed the developer agreement.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6305

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.