Add Sampler controls to all skins (Outline)

Bug #921174 reported by Sean M. Pappalardo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
jus

Bug Description

The Outline skins don't yet have sampler deck visibility. We should add it.

Tags: sampler skin

Related branches

jus (jus)
Changed in mixxx:
assignee: nobody → jus (jus)
milestone: none → 1.10.1
status: Confirmed → In Progress
Revision history for this message
jus (jus) wrote :

I`ll put the Outline1024x600-Netbook skin update here for testing. This update brings 4 sample deck to the outline skin like in the other skins.

Unfortunately there were unexpected difficulties during the update. The outline skin make use of the color scheme support in Mixxx. And this brings problems exclusive to this kind of skins.

Known bugs:
* Sample decks do not parse the <style> CSS declaration for text fields like <NumberBpm> and <Text>, even if we do net declare any CSS text color. The color scheme support does not work on these. As workaround the text properties are derived from <FgColor> in <TableView>.

The missing CSS style mean also that tooltips are the QT standard ones (yellow) for these text fields unlike all the others in Mixxx.

* It is not possible to load background images via <style> CSS declaration for Widget groups. The color scheme support does not work on these.

That means the samplers background images can not be dynamically loaded like in other skins. As workaround i put the samplers background images are static on the main background image. Unfortunately they are kinda visible even if the samplers are hidden. And it makes resizing skins even more complex.

* When switching between color schemes, the pixmaps do not change colors, they stay like in the scheme before. You need to switch back to another skin and again to the skin you want to work with.

I would not include the skin in in this state in trunk and fixing color scheme support is low priority at best.

The other way around would be to drop color scheme support for this skin too and add all features without the limitations from color schemes. But not for 1.10.1 imo.

Revision history for this message
jus (jus) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks for working on this jus. I'm for dropping color scheme support. It sounds like there are a lot of issues here that might require code changes to fix. Maybe we could provide this as a community-supported skin instead of a certified one until we can fix the issues to make it look good. In any case, I would say this is much lower priority than all the other work on your plate so it's not necessary for 1.11.0.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: 1.10.1 → none
Revision history for this message
Burnie (photoburn) wrote :

Ok, I downloaded it. But, how do I make it work for the mxxx that I allready downloaded?

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 921174] Re: Add Sampler controls to all skins (Outline)

Hi Burnie,

Depending on your OS the skin will need to be copied into different places.

On Windows, try:

c:\Program Files\Mixxx\skins
or
c:\Program Files (x86)\Mixxx\skins

on OSX,
/Applications/Mixxx.app/Contents/Resources/skins/

On Linux:
/usr/share/mixxx/skins

Just drop the Outline1024x600-Netbook skin into one of those folders, make
sure to replace or delete the existing one first.

On Wed, May 9, 2012 at 2:43 PM, Burnie <email address hidden> wrote:

> Ok, I downloaded it. But, how do I make it work for the mxxx that I
> allready downloaded?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/921174
>
> Title:
> Add Sampler controls to all skins (Outline)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/921174/+subscriptions
>

Revision history for this message
jus (jus) wrote :
jus (jus)
Changed in mixxx:
milestone: none → 1.11.0
tags: removed: outline
jus (jus)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6257

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.