"A deck is currently playing. Exit Mixxx?" error does not flash when a sampler is playing during exit.

[akash shetye]

We know that Mixxx tries to warn us that we are exiting mixxx when a deck is playing a track. It flashes the dialog that asks us "A deck is currently playing. Exit Mixxx?". However this does not happen when a sampler is playing a track. In such a case if an exit is issued, Mixxx simply exits without any warning. Though this may seem too trivial, but if we have a safeguard mechanism for currently playing decks, then why not for currently playing samples.

I also suggest that the warning be different for both cases. I am attaching a patch that fixes this bug. It works for a case in which both deck and sampler are playing. It first asks about the playing deck, if a "yes" is issued, it still asks about the playing sampler. According to what I observe, it must exit in the first, but anyhow it fixes all the possibilities.

[jus (jus)]

I wonder if we could add this fix already in 1.10.1 and not just in 1.11.0 because it contains no new functionality and eliminates an issue with the current version instead.

[RJ Skerry-Ryan (rryan)]

Thank you for the patch Akash and sorry it took me so long to take a look.

There was one minor issue with the patch -- the new for loop was over deckCount instead of samplerCount so it won't check all the samplers if there are only 2 decks. I went ahead and committed this to the 1.10 branch with a fix for that tiny bug. Congrats on your first patch to Mixxx!

Could you please sign the contributor agreement here? https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0

I've added you to the contributor list in lp:mixxx/1.10 as "Akash Shetye". Let me know if you'd rather be credited under a different name.

[akash shetye (shetyeakash)]

Yay!! Thanks for the help Ryan, my first patch there it is! I'll take a closer look at all my other patches too, I am soon migrating to Eclipse with bzr plugin and everything like Daniel suggested soon to avoid using crummy cmd line tools. Thanks again.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6243