legacyskinparser.cpp LegacySkinParser::parseBackground check NULL

Bug #914240 reported by Daniel Lindenfelser on 2012-01-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Low
Daniel Lindenfelser

Bug Description

legacyskinparser.cpp:344 and legacyskinparser.cpp:352

 if (background != NULL) {

is not correct use

if (!background->isNull()) {

RJ Skerry-Ryan (rryan) wrote :

Since background is a pointer, it should have a NULL check before dereferencing.

if (background != NULL && !background->isNull()) {

}

would be an option, but I assume that QLabel::setPixmap would ignore null or empty pixmaps anyway.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Daniel Lindenfelser (dan-lin) wrote :

yes you're right

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan) on 2012-01-10
Changed in mixxx:
assignee: nobody → Daniel Lindenfelser (dan-lin)
status: Fix Committed → In Progress
milestone: none → 1.11.0
RJ Skerry-Ryan (rryan) on 2012-01-16
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers