legacyskinparser.cpp LegacySkinParser::parseBackground check NULL

Bug #914240 reported by Daniel Lindenfelser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Lindenfelser

Bug Description

legacyskinparser.cpp:344 and legacyskinparser.cpp:352

 if (background != NULL) {

is not correct use

if (!background->isNull()) {

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Since background is a pointer, it should have a NULL check before dereferencing.

if (background != NULL && !background->isNull()) {

}

would be an option, but I assume that QLabel::setPixmap would ignore null or empty pixmaps anyway.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Daniel Lindenfelser (dan-lin) wrote :

yes you're right

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → Daniel Lindenfelser (dan-lin)
status: Fix Committed → In Progress
milestone: none → 1.11.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6240

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.