Push-buttons are getting out of sync using both mouse buttons

[Don Paul]

Mixxx 1.10.0-beta1x64 on Windows home premium 64:

Reverse and Fast Rewind buttons keep going past the start of a song - I think they should stop there.

Pressing Reverse with right and left mouse buttons together can cause reverse play to keep going, even again after pause. Repeating this action (which is not always recognised) is the only way to stop the reverse playing.

Worse still I managed to get a tune to play very fast in forward while testing this out and could only stop it by shutting down Mixxx. The Play/Pause button had no effect.

The Reverse button implementaion is not solid.

[Daniel Schürmann (daschuer)]

Note: The "going past the start of the song" issue is tracked in a separate bug #906353

I think the best solution is, to compete decouple the right and left mouse button for push-buttons.
Or is there any reason to control a push-button by the right mouse button as well?

The only reason for me the user might want to clicks the right button is when expecting latching function.
A proposal for this can be found in bug #876139. Does anyone like to see such a power-window button button for reverse-play as well?

[Daniel Schürmann (daschuer)]

One issue with wpushbutton is is the inverse mode of a single state push-button.

m_fValue = emitValue = (m_fValue == 0.0f) ? 1.0f : 0.0f;

This conflicts with the midi and keyboard buttons, which don't have such an inverse mode. I don't now if there is a use case for this function. So if not, I will remove this "feature".

[Daniel Schürmann (daschuer)]

Attached you will find a patch against lp:mixxx #2973 which should solve the most pushbutton issues.
It introduces also the power-window mode from Bug #876139.

[RJ Skerry-Ryan (rryan)]

RE: The reversing past the start of the song, that's intended behavior as the track-lead in area is treated just as part of the track itself.

[RJ Skerry-Ryan (rryan)]

Bug #876139 is now fixed so this one should be fixed as well. Thanks Daniel!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6194