library UI not updating when data changes

Bug #868468 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
RJ Skerry-Ryan
1.10
Fix Released
High
RJ Skerry-Ryan
1.9
Fix Released
High
RJ Skerry-Ryan

Bug Description

With the new library code, changes made to library data not triggered by the user are not reflected in the UI. This includes: scanning new files, bpm detection. Manually triggering a refresh of the data (like by editing a field and hitting escape) causes the data to appear correctly.

This looks like a problem with the engine not signalling the UI to redraw correctly.

Related branches

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Yup, I know why this happens and in general have a plan to fix it.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

This is really two separate bugs:

1) Added tracks (scanner, drag-n-drop, iTunes, etc.) do not automatically become cached by BaseTrackCache
2) Tracks in a library table that are already in the BaseTrackCache do not update when they are modified by Mixxx.

Fix for 2 is coming and workaround for 1 are on the way.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Proper fixes in place:

- Added tracks /except/ library scanner are automatically cached in BTC
- Tracks not in the BTC get automatically cached on first touch as a last-ditch prevention for showing blank cells.

Marking this one fixed since Bug #870544 specifically talks about the library scanner case.

Changed in mixxx:
status: Confirmed → Fix Committed
milestone: 1.10.0 → none
Revision history for this message
Owen Williams (ywwg) wrote :

If I double click to load a track, the Played checkbox does not appear checked and the Play count does not increase by one. So this isn't quite fixed.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 868468] Re: library UI not updating when data changes

I haven't merged to trunk yet (fell asleep while trying to last night :) ).
Are you trying in 1.9 ?

On Wed, Oct 12, 2011 at 9:58 AM, Owen Williams <email address hidden> wrote:

> If I double click to load a track, the Played checkbox does not appear
> checked and the Play count does not increase by one. So this isn't
> quite fixed.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/868468
>
> Title:
> library UI not updating when data changes
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/868468/+subscriptions
>

Revision history for this message
Owen Williams (ywwg) wrote :

nope, was using trunk. sleep is an acceptable explanation for this oversight so I'll let it go this time...

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

:)

Should be merged now

On Wed, Oct 12, 2011 at 1:06 PM, Owen Williams <email address hidden> wrote:

> nope, was using trunk. sleep is an acceptable explanation for this
> oversight so I'll let it go this time...
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/868468
>
> Title:
> library UI not updating when data changes
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/868468/+subscriptions
>

Revision history for this message
Owen Williams (ywwg) wrote :

I don't know if this is related, but it's hard to click the "played" checkbox to toggle that state. It seems to take two or three clicks for the checkbox to end up either off or on, whichever I want. Could this be because the UI still isn't updating correctly in response to these clicks, or is it a separate issue?

The other instances of the UI not updating have been fixed, so that's all good.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Something does seem to be wrong w/ the played checkbox -- I'll have to look
into it.

On Thu, Oct 13, 2011 at 9:26 AM, Owen Williams <email address hidden> wrote:

> I don't know if this is related, but it's hard to click the "played"
> checkbox to toggle that state. It seems to take two or three clicks for
> the checkbox to end up either off or on, whichever I want. Could this
> be because the UI still isn't updating correctly in response to these
> clicks, or is it a separate issue?
>
> The other instances of the UI not updating have been fixed, so that's
> all good.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/868468
>
> Title:
> library UI not updating when data changes
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/868468/+subscriptions
>

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6007

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.