Custom BPM Schemes got deleted when reopening Mixxx

Bug #864574 reported by jus on 2011-10-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Medium
RJ Skerry-Ryan
1.10
Medium
RJ Skerry-Ryan
1.9
Medium
RJ Skerry-Ryan

Bug Description

Tested with latest lp:mixxx/1.10 r 2846 on MacOS 10.6.8

Steps to reproduce:
1. Add a new BPM schemes in Preferences->BPM Detection
2. Hit OK button, new custom scheme is saved to mixxxbpmscheme.xml
3. Close and reopen Mixxx

Actual behavior:
mixxxbpmscheme.xml got replaced with an empty file , the custom BPM schemes are gone

Expected behavior:
The custom BPM schemes should still be in mixxxbpmscheme.xml and ready to use

Also we could include some schemes for different genres to choose from per default if this helps to improve BPM detection. See the attached custom mixxxbpmscheme.xml

Related branches

jus (jus) wrote :
RJ Skerry-Ryan (rryan) on 2011-10-02
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
RJ Skerry-Ryan (rryan) wrote :

A really dumb bug and I'm not sure why it worked in the past but not now. My current theory is QDomDocument used to not pay attention to the 'encoding="UTF-16"' line we were putting in mixxxbpmscheme.xml but at some point that was changed. Our bug is that we put 'encoding="UTF-16"' in the file, but then we don't encode it as UTF-16.

RJ Skerry-Ryan (rryan) wrote :

Fixed now. If Mixxx hasn't already overwritten the user's saved BPM scheme, then the fix tries to rescue the data.

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan) on 2011-12-25
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers