Color Scheme Processor not allowing hues above 255

Bug #816715 reported by Stevan Flores
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
RJ Skerry-Ryan
1.10
Fix Released
Low
RJ Skerry-Ryan
1.9
Fix Released
Low
RJ Skerry-Ryan

Bug Description

I was working on a skin with Schemes and I noticed weird things happening as I tried to adjust the colors using the HSVTweak filter. After hours of investigating weird, inconsistent values turning up, I think I've figured it out.

Hue values range from 0-359, starting with pure red (hue value 0) and cycling through the ROYGBIV spectrum before returning to red (360). Saturation and Value values range from 0-255, with 0 representing no saturation and completely dark (black), and 255 representing full saturation and brightest possible output. It appears that the image processor in Mixxx 1.9.0 clips color values at 255. This is appropriate for Saturation and Value, but not for Hue!

As a result, colors above Hue=255 (bright blue with a teeny bit of red, RGB value #3e00ff) are inaccessible. Once hue values hit 256, they are displayed by rolling back around to 0, e.g. color 300 (violet) is shown as color 44 (orange).

Tags: schemes

Related branches

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

How embarrassing :) I imagine this has been a bug since 1.6.x or earlier (not sure when color schemes first made it in, but it was before I joined the project)

Thanks,
RJ Ryan

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I added a fix that should go into Mixxx 1.10 (and Mixxx 1.9.2 if we ever release one)

Thanks,
RJ Ryan

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5957

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.