Display text for already played tracks in a different color

[jus]

While the checkbox in the "PLAYED" column is helpful, the distinction between played and not yet played tracks is not clear enough. This is especially true if looking from some distance , in a rush or with difficult light conditions.

I propose to introduce a new key for use in skin.xml which allows to define a separate color for tracks already played in that session. If a tracks "PLAYED" checkbox gets unchecked it should obtain the original color again.

[AndreiStefanescu (andysstef)]

Hi,

I can start working on this one.

[AndreiStefanescu (andysstef)]

Hi,

I figured out that to change the colour, I first have to find out where the TimesPlayed column in the Library table is incremented, however I couldn't find the code doing that. I saw that Library has a function setTimesPlayed and I also saw a function setTrackValueForColumn from BaseSqlTableModel but none of those get called when the value is incremented. I also saw that the value is incremented only once per application session. Shouldn't it be incremented any time the track is played? Could you please tell me where to find the code doing the incrementing?

[AndreiStefanescu (andysstef)]

I found it. The code incrementing timesPlayed is in trackobjectinfo.cpp.

[AndreiStefanescu (andysstef)]

Where are the colors for the Songs' Table View put in the xml files? I tried adding a Style tag for the Library tag but that didn't work. I also tried adding a TableView tag but that didn't work too.

[AndreiStefanescu (andysstef)]

I found the style.qss file. I guess that all new styles should be put there.

[Owen Williams (ywwg)]

Yes, the style.qss file for each skin changes the library styling. Note that we've have problems in the past with styles not being applied to all columns due to QT bugs.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5911