Many AutoDJ Improvements and Fixes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Medium
|
Daniel Schürmann |
Bug Description
The auto DJ is a really nice function but it suffers some issues when you will use it with additional manual control.
I have done some changes, which makes auto DJ useful for manual control.
* Manually to a deck loaded song is played by auto DJ
* Additional "Skip Next" Button
* Auto DJ did not use the change the "Repeat" Button any more
* "Repeat" works as desired (it temporary disables auto DJ)
* Lock fading of the two decks against each other, plus some other possible exceptions
* Enabling auto DJ always starts playback (we may discuss if it is desired)
* Next track is loaded immediately after fading (see bug 766817) also good to monitor what happens next in case browsing thou the library
* Additional "Fade Now" button (see bug 730577)
* "Fade Now" dsiables "Repeat"
Unfortunately, my two additional buttons are smashing the GUI.
Who can help repairing it?
Attached you will find my patch for trunk 2793. I will also try to commit a branch by bazaar.
Related branches
- Mixxx Development Team: Pending requested
-
Diff: 1979 lines (+1168/-231)22 files modifiedmixxx/build/depends.py (+24/-4)
mixxx/lib/soundtouch-1.6.0/STTypes.h (+1/-1)
mixxx/res/images/autodj/bottom.svg (+137/-0)
mixxx/res/images/autodj/media-playlist-shuffle.svg (+214/-0)
mixxx/res/images/autodj/stock_mail-send-receive.svg (+87/-0)
mixxx/res/mixxx.qrc (+3/-0)
mixxx/src/dlgautodj.cpp (+433/-161)
mixxx/src/dlgautodj.h (+26/-2)
mixxx/src/dlgautodj.ui (+110/-18)
mixxx/src/library/autodjfeature.cpp (+30/-24)
mixxx/src/library/autodjfeature.h (+2/-0)
mixxx/src/library/browse/browsefeature.cpp (+14/-4)
mixxx/src/library/browse/browsetablemodel.cpp (+8/-8)
mixxx/src/library/dao/cratedao.h (+2/-0)
mixxx/src/library/dao/playlistdao.cpp (+11/-3)
mixxx/src/library/dao/playlistdao.h (+3/-1)
mixxx/src/library/playlistfeature.cpp (+23/-3)
mixxx/src/library/playlistfeature.h (+3/-0)
mixxx/src/library/playlisttablemodel.cpp (+11/-0)
mixxx/src/library/playlisttablemodel.h (+1/-0)
mixxx/src/widget/wtracktableview.cpp (+22/-2)
mixxx/src/widget/wtracktableview.h (+3/-0)
Changed in mixxx: | |
status: | New → In Progress |
assignee: | nobody → Daniel Schürmann (daschuer) |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
tags: | added: autodj |
Changed in mixxx: | |
importance: | Undecided → Medium |
summary: |
- auto DJ improvement for manual control + Many AutoDJ Improvements and Fixes |
Changed in mixxx: | |
milestone: | none → 1.11.0 |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
Changed in mixxx: | |
assignee: | Daniel Schürmann (daschuer) → da2da (da23da) |
description: | updated |
Hi Daniel,
tested your patch, really useful improvements.
One small thing:
If you repeatedly hit "Enable AutoDJ" the next track disappears from the list even if it has not been played, also the play counter is still raised by 1.
Attached small fix for dlgautodj.ui makes that the additional buttons align to the left and dont expand anymore infinite.