Many AutoDJ Improvements and Fixes

Bug #782377 reported by Daniel Schürmann
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Daniel Schürmann

Bug Description

The auto DJ is a really nice function but it suffers some issues when you will use it with additional manual control.
I have done some changes, which makes auto DJ useful for manual control.
* Manually to a deck loaded song is played by auto DJ
* Additional "Skip Next" Button
* Auto DJ did not use the change the "Repeat" Button any more
* "Repeat" works as desired (it temporary disables auto DJ)
* Lock fading of the two decks against each other, plus some other possible exceptions
* Enabling auto DJ always starts playback (we may discuss if it is desired)
* Next track is loaded immediately after fading (see bug 766817) also good to monitor what happens next in case browsing thou the library
* Additional "Fade Now" button (see bug 730577)
* "Fade Now" dsiables "Repeat"

Unfortunately, my two additional buttons are smashing the GUI.
Who can help repairing it?

Attached you will find my patch for trunk 2793. I will also try to commit a branch by bazaar.

Tags: autodj

Related branches

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Revision history for this message
jus (jus) wrote :

Hi Daniel,
tested your patch, really useful improvements.

One small thing:
If you repeatedly hit "Enable AutoDJ" the next track disappears from the list even if it has not been played, also the play counter is still raised by 1.

Attached small fix for dlgautodj.ui makes that the additional buttons align to the left and dont expand anymore infinite.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi jus,

Thank you for testing. I have pushed a new version, fixing the GUI problem and the auto DJ staring Problem.

There is still an issue with the played counter, because it did not count the playes, but the loads on a deck.

I think, will post a separate bug.

Your GUI fix did not help for Outline-Netbook theme. I have deleted the static text. Now it works, but why?

jus (jus)
Changed in mixxx:
status: New → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Revision history for this message
jus (jus) wrote :

With the additional buttons there is simply not enough place in the current Outline skins to display all buttons and text in one row.
So the library frame breaks from the defined dimensions (in skin.xml).

I think it would be ok to put the buttons + the help text in 2 rows as there will be more buttons anyway in the the near future, e.g. for custom transition time https://bugs.launchpad.net/mixxx/+bug/729640

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Fix is not commited to trunk yet. The attatched Patch will be obsolete, after merging lp:~daschuer/mixxx/autodj

Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
pi r squared (aps80) wrote :

I really like the improvements that have gone into your branch, and in fact use your branch merged with the official 1.10 one as my main playout environment.

Will this branch be ultimately compatible with the changes Tom Mast is making (https://code.launchpad.net/~thomasomast/mixxx/features_autodj), as I am also liking the look of those (in particular, custom "out"-points)?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Tom is starting to merge sections from this code into his branch. So I hope at the end you will have the advantages of both branches within one.

RJ Skerry-Ryan (rryan)
tags: added: autodj
Changed in mixxx:
importance: Undecided → Medium
RJ Skerry-Ryan (rryan)
summary: - auto DJ improvement for manual control
+ Many AutoDJ Improvements and Fixes
jus (jus)
Changed in mixxx:
milestone: none → 1.11.0
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
da2da (da23da)
Changed in mixxx:
assignee: Daniel Schürmann (daschuer) → da2da (da23da)
da2da (da23da)
description: updated
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hi da2da

Thanks for your patch and welcome to Mixxx development!

We use git now -- you can find our master branch on GitHub:
https://github.com/mixxxdj/mixxx

Your patch works but it is ideal for us to do code review via GitHub pull requests. Are you familiar with those? If not we can review your patch but it makes commenting harder.

Also, this bug is now "Fix Released" which mean it is complete (since Daniel's fixes were merged). Could you file a separate bug please?

Changed in mixxx:
assignee: da2da (da23da) → Daniel Schürmann (daschuer)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Oops, I misundestood the Launchpad email and thought Daniel's original description was a message from you.

Would you like to work on improving AutoDJ? Ideally please submit pull requests via GitHub and file bugs about the functionality you would like to add. Thanks!

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5892

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.