Build against system libs

[Alessio Treglia]

Please provide a clean way to avoid building against the local copies of the libraries shipped with the tarball (e.g. soundtouch).

[RJ Skerry-Ryan (rryan)]

I believe Debian already has a patch for soundtouch we could take.

[Daniel Schürmann (daschuer)]

Note:
In the Ubuntu libsoundtouch-dev 1.6.0-2 package the x86 optimisation is disabled.
We have to check, if using the system libs has any performance regressions.
See also Bug #887741.

[Nico Schlömer (nschloe)]

I just bumped into this when upgrading the Debian build. Debian in fact patches out Mixxx's own soundtouch. This is based on Debian's policy not to allow bundled libraries. To reduce the workload for Debian maintainers, we could add a build flag (default OFF) that allows linking against system soundtouch.

[Daniel Schürmann (daschuer)]

Debians soundtouch does not work reliable with Mixxx, since it is not compiled with SSE2 enabled.
We need soundtouch espessially for old devices and performance matters there a lot.
So we have to state clear, that ripping out sountouch from Mixxx is not desired.

[Daniel Schürmann (daschuer)]

An other issue is that whole Mixxx does not work reliably without SSE enabled.
We should makes sure that the Debian version of Mixxx 2.0 is compiled with SSE2 enabled.
optimize=portable

[Daniel Schürmann (daschuer)]

We should remove hidapi from the libs folder and move it to the buildserver repro.
This will likely be done anyway by the different distros.
If you agree, I will prepare pull requests.

Any ideas?

[Sean M. Pappalardo (pegasus-renegadetech)]

If we have a problem with Debian's own Soundtouch, what is the best solution, Alessio? Would creating a libsoundtouch-mixxx package that installs alongside the system one be suitable? Or should we somehow detect at run time whether the linked Soundtouch has the optimizations we need and show a warning message if not? (And provide a link to information on our PPA.)

In any case, this bug is about allowing the Debian package maintainer to easily create a Mixxx package that meets Debian's requirements, so regardless of the performance consequences, we need to do this. I think a "debianpackage" build flag is the easiest way.

[Daniel Schürmann (daschuer)]

Does Allessio listen to this thread?

IMHO Debian allows to be of their rules for a good reason. No one wants to include a bitching mixxx into the repositoriies just to meet some general rules.

The soundtouch issue applies only to 32 bit builds. So crating soundtouch-sse2 package and let mixxx depend on it will work. This package can replace the default package. All other apps will benefit from it.

Mixxx itself cannot run on a non see hardware and it strictly requires the "Portable" flag to be usable. So introducing a Debian build option is no option.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5842